Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCK-7931: fix commenting out of DROP statements with a checkbox #226

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Vitalii4as
Copy link
Contributor

@Vitalii4as Vitalii4as commented Sep 9, 2024

Sub-taskHCK-7931 There should be a acheckbox to comment out all DROP statements

Content

DROP statements where not marked properly, therefore the checkbox didn't appear in UI

@Vitalii4as Vitalii4as self-assigned this Sep 9, 2024
Copy link

sonarqubecloud bot commented Sep 9, 2024

@VitaliiBedletskyi VitaliiBedletskyi enabled auto-merge (squash) September 9, 2024 12:24
@thomas-jakemeyn thomas-jakemeyn enabled auto-merge (squash) September 9, 2024 14:28
@thomas-jakemeyn thomas-jakemeyn merged commit 709d124 into develop Sep 9, 2024
10 checks passed
@thomas-jakemeyn thomas-jakemeyn deleted the fix/HCK-7931 branch September 9, 2024 14:56
VitaliiBedletskyi pushed a commit that referenced this pull request Sep 9, 2024
* HCK-7916: default config for variant data type

* HCK-7931: fix commenting out of DROP statements with a checkbox (#226)

* HCK-7916: added Variant version bound

---------

Co-authored-by: Vitalii Yarmus <[email protected]>
chulanovskyi-bs pushed a commit that referenced this pull request Sep 13, 2024
* Hck 7915 add runtime 15 to the list of available versions and make it the default (#229)

* HCK-7915: added Runtime 15 option

* HCK-7915: added Runtime 15 to model config

* HCK-7916: default config for variant data type (#228)

* HCK-7916: default config for variant data type

* HCK-7931: fix commenting out of DROP statements with a checkbox (#226)

* HCK-7916: added Variant version bound

---------

Co-authored-by: Vitalii Yarmus <[email protected]>

* HCK-7919: add Variant type to RE from file (Hive) grammar (#232)

* HCK-7898: added config for variant synonym (#233)

* HCK-7920: implemented variant subtype resolve logic on REing from ins… (#234)

* HCK-7920: implemented variant subtype resolve logic on REing from instance

* HCK-7920: moved columns with json detection logic to separate function

* HCK-7920: fixed remarks

* HCK-7920: changed variant type order in config

* HCK-7920: fixed json types ordering

* HCK-7920: covered empty list case

* HCK-7898: removed variant from being default

* HCK-7898: removed redundant config

---------

Co-authored-by: Vitalii Yarmus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants