Skip to content

Commit

Permalink
HCK-9173: comment out inactive schema statement in script (#45)
Browse files Browse the repository at this point in the history
<!--do not remove this marker, its needed to replace info when ticket
title is updated -->
<!--jira-description-action-hidden-marker-start-->

<table>
<td>
<a href="https://hackolade.atlassian.net/browse/HCK-9173"
title="HCK-9173" target="_blank"><img alt="Sub-bug"
src="https://hackolade.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium"
/>HCK-9173</a> Statements are still incorrectly present in DDL/Script
tab after 'isActivated' is disabled
  </td></table>
  <br />
 

<!--jira-description-action-hidden-marker-end-->
## Content

You have no Jira task for this PR? Describe your changes here...

...

## Technical details

You feel the need to provide technical explanations? You can do it
here...

...
  • Loading branch information
AlikRakhmonov authored Dec 19, 2024
1 parent 5ee1a50 commit ae0b7de
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions forward_engineering/ddlProvider/ddlProvider.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,11 @@ module.exports = (baseProvider, options, app) => {
schemaName: containerData.name,
authorizationName: containerData.authorizationName,
dataCapture: containerData.dataCapture,
isActivated: containerData.isActivated,
};
},

createSchema({ schemaName, ifNotExist, authorizationName, dataCapture }) {
createSchema({ schemaName, ifNotExist, authorizationName, dataCapture, isActivated = true }) {
const schemaStatement = assignTemplates({
template: templates.createSchema,
templateData: {
Expand All @@ -77,7 +78,7 @@ module.exports = (baseProvider, options, app) => {
},
});

return schemaStatement;
return commentIfDeactivated(schemaStatement, { isActivated });
},

hydrateColumn({ columnDefinition, jsonSchema, schemaData, definitionJsonSchema = {} }) {
Expand Down

0 comments on commit ae0b7de

Please sign in to comment.