Skip to content

Commit

Permalink
HCK-6346: Min and Max Properties fields should only be available for …
Browse files Browse the repository at this point in the history
…types Map and Object (#21)

* HCK-6346: fix field level config

* HCK-6346: fix typo in localization
  • Loading branch information
Nightlngale authored and hackolade-bot committed Jun 13, 2024
1 parent 1bb5605 commit 7237904
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.DS_Store
.vscode
.idea
2 changes: 1 addition & 1 deletion localization/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"TOOLBAR___ADD_ATTRIBUTE": "Add Column",
"TOOLBAR___INSERT_FIELD": "Insert Column",
"TOOLBAR___APPEND_FIELD": "Append Column",
"TOOLBAR___TOGGLE_FIELD_DETAILS": "Toogle field details",
"TOOLBAR___TOGGLE_FIELD_DETAILS": "Toggle field details",
"TOOLBAR___SHOW_FOREIGN_MASTER": "Toggle foreign master",
"TOOLBAR___SHOW_MODEL_VIEW": "Toggle model views",
"TOOLBAR___DISTRIBUTE_ORTHOGONALLY": "Distribute tables orthogonally",
Expand Down
18 changes: 18 additions & 0 deletions properties_pane/field_level/fieldLevelConfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -3528,6 +3528,24 @@ making sure that you maintain a proper JSON format.
],
"defaultValue": "object"
},
{
"propertyName": "Min Properties",
"propertyKeyword": "minProperties",
"propertyType": "numeric",
"dependency": {
"key": "subtype",
"value": "object"
}
},
{
"propertyName": "Max Properties",
"propertyKeyword": "maxProperties",
"propertyType": "numeric",
"dependency": {
"key": "subtype",
"value": "object"
}
},
{
"propertyName": "Comments",
"propertyKeyword": "description",
Expand Down
2 changes: 0 additions & 2 deletions types/geometry.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
"foreignCollection": "",
"foreignField": [],
"dependencies": [],
"minProperties": "",
"maxProperties": "",
"additionalProperties": false,
"enum": []
},
Expand Down

0 comments on commit 7237904

Please sign in to comment.