HCK-7254: fix FE script generation for the time unit partitioning using DATE type column #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng DATE type column
chulanovskyi-bs
previously approved these changes
Jul 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
…ng DATE type column (#59)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
chulanovskyi-bs
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Time-unit column partitioning is suitable for the
DATE,TIMESTAMP, orDATETIMEcolumns within a table. For more details, refer to the documentation.When defining a partition expression, ensure that columns of type
TIMESTAMPorDATETIMEare enclosed within theDATE()function. On the other hand, if you're using columns of typeDATE, there's no need to include this wrapping function. (documentation)Technical details
To handle partitioning expressions for different column types, I created a helper function. This function generates the appropriate expression based on the type of column.