Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated newUserForm.js to MUI #1726

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Conversation

ntrehan
Copy link
Member

@ntrehan ntrehan commented Aug 12, 2024

Fixes #1693

What changes did you make and why did you make them ?

  • Changed the contents of NewUserForm.js from regular HTML to Material UI as part of migration

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals of empty form before changes are applied

image

Visuals of empty after changes are applied

image

Visuals of filled form before changes are applied

image

Visuals of filled form before changes are applied

image

Visuals of filled form after changes are applied

image

Test 1 : create a new user that has never attended Hack Night before. Result - Passed

image

Test 2 : create a new user that has attended Hack Night before. Result - Passed

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ntrehan-1693 development
git pull https://github.com/ntrehan/VRMS.git 1693

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting in the work on this one. It was definitely more.

We're planning on removing the HackNight question later on, so no need to remove switch that to an MUI date picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/presentational/newUserForm.js
2 participants