editMeetingTimes - Replaced HTML with MUI applicable components #1702
+81
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
trillium
changed the title
trillium
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Going to approve these changes for editMeetingTimes.js
The other file changes have beeen approved as well though they're from other PRs (fine for now).
We will need to revisit this component in the future to use a modal provided by MUI, but that is outside the scope of this PR. Thank you!
|
@JackHaeg can I ping you to track that this component needs to be transferred to a modal provided by MUI? I think we already have an issue open for it |
|
@trillium to create tracking issue |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1665
What changes did you make and why did you make them ?