Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent layout shift admin page #1676

Merged

Conversation

angela-lee1
Copy link
Member

@angela-lee1 angela-lee1 commented Jun 19, 2024

Fixes #1645

What changes did you make and why did you make them?

  • made changes in auth.js to render error container always, prevent layout shifting
  • set height in the style sheet for error messages with multi lines

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b awlFCCamp-prevent-layout-shift-admin-page development
git pull https://github.com/awlFCCamp/VRMS.git prevent-layout-shift-admin-page

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awlFCCamp This is great! Thanks for contributing.

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thanks for accounting for multi-line error messages :)

@trillium trillium merged commit ecafd8a into hackforla:development Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On admin login page, make error state " " to prevent layout shift
3 participants