Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability for PMs to edit Project Information on VRMS #1634

Merged

Conversation

lcchrty
Copy link
Member

@lcchrty lcchrty commented May 13, 2024

Fixes #1630

What changes did you make and why did you make them?

  • Conditionally rendering the edit button (badge) on the project form based on whether or not auth.user.acessLevel === 'admin'
  • If not the user is not an admin, the user should not have the ability to edit the project information but will be able to add and edit events.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2024-05-12 at 17 12 47 Screenshot 2024-05-12 at 17 12 58
Visuals after changes are applied Screenshot 2024-05-12 at 17 16 03 Screenshot 2024-05-12 at 17 16 15 Screenshot 2024-05-12 at 17 16 09

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b lcchrty-1630-user-project-edit-access development
git pull https://github.com/lcchrty/VRMS.git 1630-user-project-edit-access

@lcchrty lcchrty changed the title 1630 user project edit access Remove ability for PMs to edit Project Information on VRMS May 13, 2024
@@ -223,52 +221,65 @@ export default function ProjectForm({
</FormControl>
</Grid>
);
console.log(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to stay? Everything else looks good / works as expected

@bkmorgan3
Copy link
Member

@lcchrty Youre going to have to merge dev in now.

@JackHaeg
Copy link
Member

@bkmorgan3 Just checking in - are we good to merge this PR?

@bkmorgan3 bkmorgan3 merged commit 4474bb6 into hackforla:development May 16, 2024
5 checks passed
@JackHaeg
Copy link
Member

Thanks @bkmorgan3! 👍

@trillium
Copy link
Member

Hey @lcchrty , I believe this PR indroduced a bug.

TitltedBox is supposed to contain children, not be its own closed element

// old 

<TitledBox>
  { content }
</TitledBox>

// this PR

<TitledBox />
{ content }

@trillium
Copy link
Member

#1646

@lcchrty
Copy link
Member Author

lcchrty commented Jun 3, 2024

hey @spiteless - I picked up the issue for the bug I introduced. thanks for catching* this!

@trillium
Copy link
Member

trillium commented Jun 3, 2024

Thanks!

As a reminder it's on the team as a whole to make sure that the code merged works as intended, so no harm done :)

Thanks for picking up the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ability for PMs to edit Project Information on VRMS
4 participants