Merge pull request certbot#2538 from letsencrypt/augeas-lens-fix

Augeas Lens fix for Section Headings V2
hackersdotmu · Feb 25, 2016 · 3da289e · 3da289e
2 parents 07d0452 + 13a4089
commit 3da289e
Show file tree

Hide file tree

Showing 2 changed files with 287 additions and 4 deletions.
diff --git a/letsencrypt-apache/letsencrypt_apache/augeas_lens/httpd.aug b/letsencrypt-apache/letsencrypt_apache/augeas_lens/httpd.aug
@@ -45,9 +45,8 @@ autoload xfm
 let dels (s:string)     = del s s
 
 (* deal with continuation lines *)
-let sep_spc    =  del /([ \t]+|[ \t]*\\\\\r?\n[ \t]*)/ " "
-
-let sep_osp             = Sep.opt_space
+let sep_spc             = del /([ \t]+|[ \t]*\\\\\r?\n[ \t]*)/ " "
+let sep_osp             = del /([ \t]*|[ \t]*\\\\\r?\n[ \t]*)/ ""
 let sep_eq              = del /[ \t]*=[ \t]*/ "="
 
 let nmtoken             = /[a-zA-Z:_][a-zA-Z0-9:_.-]*/
@@ -60,7 +59,7 @@ let indent              = Util.indent
 
 (* borrowed from shellvars.aug *)
 let char_arg_dir  = /([^\\ '"{\t\r\n]|[^ '"{\t\r\n]+[^\\ \t\r\n])|\\\\"|\\\\'/
-let char_arg_sec  = /[^ '"\t\r\n>]|\\\\"|\\\\'/
+let char_arg_sec  = /([^\\ '"\t\r\n>]|[^ '"\t\r\n>]+[^\\ \t\r\n>])|\\\\"|\\\\'/
 let char_arg_wl   = /([^\\ '"},\t\r\n]|[^ '"},\t\r\n]+[^\\ '"},\t\r\n])/
 
 let cdot = /\\\\./

diff --git a/...apache/letsencrypt_apache/tests/apache-conf-files/passing/section-continuations-2525.conf b/...apache/letsencrypt_apache/tests/apache-conf-files/passing/section-continuations-2525.conf
@@ -0,0 +1,284 @@
+
+NameVirtualHost 0.0.0.0:7080
+NameVirtualHost [00000:000:000:000::0]:7080
+NameVirtualHost 0.0.0.0:7080
+
+NameVirtualHost 127.0.0.1:7080
+NameVirtualHost 0.0.0.0:7081
+NameVirtualHost [0000:000:000:000::2]:7081
+NameVirtualHost 0.0.0.0:7081
+
+NameVirtualHost 127.0.0.1:7081
+
+ServerName "example.com"
+ServerAdmin "[email protected]"
+
+DocumentRoot /tmp
+
+<IfModule mod_logio.c>
+	LogFormat "%a %l %u %t \"%r\" %>s %O \"%{Referer}i\" \"%{User-Agent}i\"" plesklog
+</IfModule>
+<IfModule !mod_logio.c>
+	LogFormat "%a %l %u %t \"%r\" %>s %b \"%{Referer}i\" \"%{User-Agent}i\"" plesklog
+</IfModule>
+
+TraceEnable off
+
+ServerTokens ProductOnly
+
+<Directory "/var/www/vhosts">
+	AllowOverride "All"
+	Options SymLinksIfOwnerMatch
+	Order allow,deny
+	Allow from all
+
+	<IfModule sapi_apache2.c>
+		php_admin_flag engine off
+	</IfModule>
+
+	<IfModule mod_php5.c>
+		php_admin_flag engine off
+	</IfModule>
+
+</Directory>
+
+<Directory "/usr/lib/mailman">
+	AllowOverride "All"
+	Options SymLinksIfOwnerMatch
+	Order allow,deny
+	Allow from all
+	<IfModule sapi_apache2.c>
+		php_admin_flag engine off
+	</IfModule>
+	<IfModule mod_php5.c>
+		php_admin_flag engine off
+	</IfModule>
+</Directory>
+
+<IfModule mod_headers.c>
+	Header add X-Powered-By PleskLin
+</IfModule>
+
+<IfModule mod_security2.c>
+	SecRuleEngine DetectionOnly
+	SecRequestBodyAccess On
+	SecRequestBodyLimit 134217728
+	SecResponseBodyAccess Off
+	SecResponseBodyLimit 524288
+	SecAuditEngine On
+	SecAuditLog "/var/log/modsec_audit.log"
+	SecAuditLogType serial
+</IfModule>
+
+#Include "/etc/httpd/conf/plesk.conf.d/ip_default/*.conf"
+
+<VirtualHost \
+	0.0.0.0:7080 \
+	[00000:000:000:0000::2]:7080 \
+	0.0.0.0:7080 \
+	127.0.0.1:7080 \
+	>
+	ServerName "default"
+	UseCanonicalName Off
+	DocumentRoot /tmp
+	ScriptAlias "/cgi-bin/" "/var/www/vhosts/default/cgi-bin"
+
+	<IfModule mod_ssl.c>
+		SSLEngine off
+	</IfModule>
+
+	<Directory "/var/www/vhosts/default/cgi-bin">
+		AllowOverride None
+		Options None
+		Order allow,deny
+		Allow from all
+	</Directory>
+
+	<Directory "/var/www/vhosts/default/htdocs">
+
+		<IfModule sapi_apache2.c>
+			php_admin_flag engine on
+		</IfModule>
+
+		<IfModule mod_php5.c>
+			php_admin_flag engine on
+		</IfModule>
+
+	</Directory>
+
+</VirtualHost>
+
+<IfModule mod_ssl.c>
+
+	<VirtualHost \
+		0.0.0.0:7081 \
+		127.0.0.1:7081 \
+		>
+		ServerName "default-0_0_0_0"
+		UseCanonicalName Off
+		DocumentRoot /tmp
+		ScriptAlias "/cgi-bin/" "/var/www/vhosts/default/cgi-bin"
+
+		SSLEngine on
+		SSLVerifyClient none
+		SSLCertificateFile /etc/ssl/certs/ssl-cert-snakeoil.pem
+
+		<Directory "/var/www/vhosts/default/cgi-bin">
+			AllowOverride None
+			Options None
+			Order allow,deny
+			Allow from all
+		</Directory>
+
+		<Directory "/var/www/vhosts/default/htdocs">
+
+			<IfModule sapi_apache2.c>
+				php_admin_flag engine on
+			</IfModule>
+
+			<IfModule mod_php5.c>
+				php_admin_flag engine on
+			</IfModule>
+
+		</Directory>
+
+	</VirtualHost>
+	<VirtualHost \
+		[00000:000:000:000::2]:7081 \
+		127.0.0.1:7081 \
+		>
+		ServerName "default-0000_000_000_00000__2"
+		UseCanonicalName Off
+		DocumentRoot /tmp
+		ScriptAlias "/cgi-bin/" "/var/www/vhosts/default/cgi-bin"
+
+		SSLEngine on
+		SSLVerifyClient none
+		SSLCertificateFile /etc/ssl/certs/ssl-cert-snakeoil.pem
+
+		<Directory "/var/www/vhosts/default/cgi-bin">
+			AllowOverride None
+			Options None
+			Order allow,deny
+			Allow from all
+		</Directory>
+
+		<Directory "/var/www/vhosts/default/htdocs">
+
+			<IfModule sapi_apache2.c>
+				php_admin_flag engine on
+			</IfModule>
+
+			<IfModule mod_php5.c>
+				php_admin_flag engine on
+			</IfModule>
+
+		</Directory>
+
+	</VirtualHost>
+	<VirtualHost \
+		0.0.0.0:7081 \
+		127.0.0.1:7081 \
+		>
+		ServerName "default-0_0_0_0"
+		UseCanonicalName Off
+		DocumentRoot /tmp
+		ScriptAlias "/cgi-bin/" "/var/www/vhosts/default/cgi-bin"
+
+		SSLEngine on
+		SSLVerifyClient none
+		SSLCertificateFile /etc/ssl/certs/ssl-cert-snakeoil.pem
+
+		#SSLCACertificateFile "/usr/local/psa/var/certificates/cert-nLy6Z1"
+
+		<Directory "/var/www/vhosts/default/cgi-bin">
+			AllowOverride None
+			Options None
+			Order allow,deny
+			Allow from all
+		</Directory>
+
+		<Directory "/var/www/vhosts/default/htdocs">
+
+			<IfModule sapi_apache2.c>
+				php_admin_flag engine on
+			</IfModule>
+
+			<IfModule mod_php5.c>
+				php_admin_flag engine on
+			</IfModule>
+
+		</Directory>
+
+	</VirtualHost>
+
+</IfModule>
+
+<VirtualHost \
+	0.0.0.0:7080 \
+	[0000:000:000:000::2]:7080 \
+	0.0.0.0:7080 \
+	127.0.0.1:7080 \
+	>
+	DocumentRoot /tmp
+	ServerName lists
+	ServerAlias lists.*
+	UseCanonicalName Off
+
+	ScriptAlias "/mailman/" "/usr/lib/mailman/cgi-bin/"
+
+	Alias "/icons/" "/var/www/icons/"
+	Alias "/pipermail/" "/var/lib/mailman/archives/public/"
+
+	<IfModule mod_ssl.c>
+		SSLEngine off
+	</IfModule>
+
+	<Directory "/var/lib/mailman/archives/">
+		Options FollowSymLinks
+		Order allow,deny
+		Allow from all
+	</Directory>
+
+</VirtualHost>
+
+<IfModule mod_ssl.c>
+	<VirtualHost \
+		0.0.0.0:7081 \
+		[00000:000:000:0000::2]:7081 \
+		0.0.0.0:7081 \
+		127.0.0.1:7081 \
+		>
+		DocumentRoot /tmp
+		ServerName lists
+		ServerAlias lists.*
+		UseCanonicalName Off
+
+		ScriptAlias "/mailman/" "/usr/lib/mailman/cgi-bin/"
+
+		Alias "/icons/" "/var/www/icons/"
+		Alias "/pipermail/" "/var/lib/mailman/archives/public/"
+
+		SSLEngine on
+		SSLVerifyClient none
+		SSLCertificateFile /etc/ssl/certs/ssl-cert-snakeoil.pem
+
+		<Directory "/var/lib/mailman/archives/">
+			Options FollowSymLinks
+			Order allow,deny
+			Allow from all
+		</Directory>
+
+	</VirtualHost>
+</IfModule>
+
+<IfModule mod_rpaf.c>
+	RPAFproxy_ips 0.0.0.0 [00000:000:000:00000::2] 0.0.0.0
+</IfModule>
+<IfModule mod_rpaf-2.0.c>
+	RPAFproxy_ips 0.0.0.0 [0000:000:000:0000::2] 0.0.0.0
+</IfModule>
+<IfModule mod_remoteip.c>
+	RemoteIPInternalProxy 0.0.0.0 [0000:000:000:0000::2] 0.0.0.0
+	RemoteIPHeader X-Forwarded-For
+</IfModule>