Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch the star #1308

Closed
wants to merge 0 commits into from
Closed

Catch the star #1308

wants to merge 0 commits into from

Conversation

mesaumya
Copy link
Contributor

Your checklist for this pull request

Author name

Mizuki (Saumya)

About your game

It's about a reindeer catching the star while having a side quest of collecting the gifts.

It can be played by using WASD to move, J to restart, Move towards the star, and gifts.

Code

Check off the items that are true.

  • The game was made using the Sprig editor.
  • The game is placed in the in the /games directory.
  • The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
  • The game runs without errors.
  • The name of the file/game contains only alphanumeric characters, -s, or _s.
  • The game name is not the same as the others from gallery

Image (If an image is used)

Thanks for your PR!

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 8:59pm

Copy link

vercel bot commented Dec 18, 2023

@mesaumya is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – sprig December 18, 2023 14:33 Inactive
@grymmy grymmy self-assigned this Dec 18, 2023
@grymmy grymmy self-requested a review December 18, 2023 18:20
@grymmy grymmy added the submission Game submission label Dec 18, 2023
@grymmy
Copy link
Contributor

grymmy commented Dec 18, 2023

Hey @mesaumya ! Thanks so much for your Sprig game contribution!

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Can you please modify the name of your game (and screenshot img) to contain only alphanumeric characters, dashes (-), and underscores (_)? The names between the screenshot and game should also match exactly (i.e. game.js and game.png).

@LucasHT22
Copy link
Member

You can just add again the image but with a new title, I know that is hard to rename a image, @mesaumya

@vercel vercel bot temporarily deployed to Preview – sprig December 19, 2023 03:52 Inactive
@mesaumya
Copy link
Contributor Author

mesaumya commented Dec 19, 2023 via email

@vercel vercel bot temporarily deployed to Preview – sprig December 19, 2023 03:54 Inactive
@mesaumya
Copy link
Contributor Author

mesaumya commented Dec 19, 2023 via email

@mesaumya
Copy link
Contributor Author

mesaumya commented Dec 19, 2023 via email

@grymmy
Copy link
Contributor

grymmy commented Dec 19, 2023

Hey! Do I need to create another new pull request?

On Tue, Dec 19, 2023 at 12:23 AM graham @.> wrote: @.* requested changes on this pull request. Hi there! Can you please modify the name of your game (and screenshot img) to contain only alphanumeric characters, dashes (-), and underscores (_)? The names between the screenshot and game should also match exactly (i.e. game.js and game.png). — Reply to this email directly, view it on GitHub <#1308 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARECNPO66ODVM3L7YM4MCL3YKCGKHAVCNFSM6AAAAABAZT56KOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBXGUZDGNRVGM . You are receiving this because you were mentioned.Message ID: @.***>

No, we will just focus on perfecting this one :) Thanks for renaming those files!

@LucasHT22
Copy link
Member

Where did you hear about Sprig, @mesaumya ?

@mesaumya
Copy link
Contributor Author

mesaumya commented Dec 20, 2023 via email

@grymmy
Copy link
Contributor

grymmy commented Dec 20, 2023

@mesaumya Please bear with me, I'm somewhat new to app reviewing, will post feedback here shortly.

@mesaumya
Copy link
Contributor Author

no no @grymmy I was just asking to see if I could be a help, if needed

@grymmy
Copy link
Contributor

grymmy commented Dec 20, 2023

@mesaumya please ignore the closing of this PR - technical difficulties, was attempting to update your PR but slightly botched - will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
submission Game submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants