-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch the star #1308
Catch the star #1308
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mesaumya is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
Hey @mesaumya ! Thanks so much for your Sprig game contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
Can you please modify the name of your game (and screenshot img) to contain only alphanumeric characters, dashes (-), and underscores (_)? The names between the screenshot and game should also match exactly (i.e. game.js and game.png).
You can just add again the image but with a new title, I know that is hard to rename a image, @mesaumya |
Okay yes, Sorry I misinterpreted it a bit earlier. Just did it both. I
apologize for the confusion.
…On Tue, Dec 19, 2023 at 12:23 AM graham ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi there!
Can you please modify the name of your game (and screenshot img) to
contain only alphanumeric characters, dashes (-), and underscores (_)? The
names between the screenshot and game should also match exactly (i.e.
*game.js* and *game.png*).
—
Reply to this email directly, view it on GitHub
<#1308 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARECNPO66ODVM3L7YM4MCL3YKCGKHAVCNFSM6AAAAABAZT56KOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBXGUZDGNRVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No, It's fine. Just renamed the image!
…On Tue, Dec 19, 2023 at 5:41 AM Lucas ***@***.***> wrote:
You can just add again the image but with a new title, I know that is hard
to rename a image, @mesaumya <https://github.com/mesaumya>
—
Reply to this email directly, view it on GitHub
<#1308 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARECNPMSZEBV3SUCQF577TLYKDLSBAVCNFSM6AAAAABAZT56KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRRHA4TENRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hey! Do I need to create another new pull request?
…On Tue, Dec 19, 2023 at 12:23 AM graham ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi there!
Can you please modify the name of your game (and screenshot img) to
contain only alphanumeric characters, dashes (-), and underscores (_)? The
names between the screenshot and game should also match exactly (i.e.
*game.js* and *game.png*).
—
Reply to this email directly, view it on GitHub
<#1308 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARECNPO66ODVM3L7YM4MCL3YKCGKHAVCNFSM6AAAAABAZT56KOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBXGUZDGNRVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No, we will just focus on perfecting this one :) Thanks for renaming those files! |
Where did you hear about Sprig, @mesaumya ? |
Through the email for hack club leaders, also is there some sort of problem?
…On Wed, Dec 20, 2023 at 4:31 PM Lucas ***@***.***> wrote:
Where did you hear about Sprig, @mesaumya <https://github.com/mesaumya> ?
—
Reply to this email directly, view it on GitHub
<#1308 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARECNPLBOCTK7T7ZLDHUOJTYKLAQ3AVCNFSM6AAAAABAZT56KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUGI3TMOBUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@mesaumya Please bear with me, I'm somewhat new to app reviewing, will post feedback here shortly. |
no no @grymmy I was just asking to see if I could be a help, if needed |
@mesaumya please ignore the closing of this PR - technical difficulties, was attempting to update your PR but slightly botched - will fix. |
Your checklist for this pull request
Author name
Mizuki (Saumya)
About your game
It's about a reindeer catching the star while having a side quest of collecting the gifts.
It can be played by using WASD to move, J to restart, Move towards the star, and gifts.
Code
Check off the items that are true.
/games
directory.-
s, or_
s.Image (If an image is used)
/games/img
directory.