Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International morse code trainer #1307

Merged
merged 4 commits into from
Dec 21, 2023
Merged

International morse code trainer #1307

merged 4 commits into from
Dec 21, 2023

Conversation

yutarour
Copy link
Contributor

@yutarour yutarour commented Dec 18, 2023

Your checklist for this pull request

Author name

Author: Yuuta

About your game

What is your game about?

  • This game is about learning international morse code. Morse code used to be used for communication, and is still today via the Ham radio service. However, learning it is a pain. Therefore, I tried making it a flashcard/game-like system using sprig.

How do you play your game?

  • This game has two modes. A text to morse and a morse to text mode. The text to morse code has a interface that allows the user to go through the characters of the alphabet, select the letter and type out a message. The morse to text mode has a interface that allows the user to input morse code and convert it to the alphabet which can be used to learn morse code, and test to see which sequence of dots and dashes is equal to which character. All of the relavant playing instructions i.e. button presses are present in the game.

Code

Check off the items that are true.

  • The game was made using the Sprig editor.
  • The game is placed in the in the /games directory.
  • The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
  • The game runs without errors.
  • The name of the file/game contains only alphanumeric characters, -s, or _s.
  • The game name is not the same as the others from gallery

Image (If an image is used)

Thanks for your PR!

Copy link

vercel bot commented Dec 18, 2023

@yutarour is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@yutarour yutarour changed the title Added Morse_trainer.js and associated thumbnail International morse code trainer Dec 18, 2023
Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Where did you hear about Sprig?

@yutarour
Copy link
Contributor Author

I was looking through things to do over winter break and was reading e-mails and saw it being mentioned in one of the newsletters.

@grymmy grymmy added the submission Game submission label Dec 18, 2023
Copy link
Contributor Author

@yutarour yutarour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what you want me to change...

@aramshiva
Copy link
Member

Hey! Just wait, Lucas is out on vacation. @grymmy might be able to help.

@LucasHT22
Copy link
Member

Sorry for the delay @yutarour ! Thanks @aramshiva :)
What should I do after this screen?
Screenshot_20231218-211837.png

@yutarour
Copy link
Contributor Author

You can decode the morse code you entered by pressing the a button which will run the decoding code, turning the morse code (one character at a time) text, and adding it to the buffer characters which is displayed. Or, you can go try the text to morse part of the code which involves selecting a character, by scrolling through the character list and writing a message.

@LucasHT22
Copy link
Member

Could you wait until tomorrow night? I want to take a more careful review and I'm currently traveling, I'm back to my "office" tomorrow night:)

Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 9:05pm

Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! My flight delayed. Could you explain the "toggle sound"?

@LucasHT22 LucasHT22 self-assigned this Dec 21, 2023
@yutarour
Copy link
Contributor Author

No problem! Flight delays are a very common thing to happen during the winter traveling season.
That is a currently unimplemented feature that plans to be implemented in the near future. This is because the tone feature of the Sprig editor is a little finicky and making it produce a short tone, delay, produce a long tone makes all of the tones happen at once causing a jumble of notes.

@LucasHT22
Copy link
Member

True, so could you remove the option? if isn't implemented i think it's better remove:)

@vercel vercel bot temporarily deployed to Preview – sprig December 21, 2023 21:04 Inactive
@yutarour
Copy link
Contributor Author

Ok, done

Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Congrats:)
If you're a teen, you can get your sprig here! https://sprig-order.hackclub.dev/

Hack Clubbers would love to see this! Just post a link and 1-2 sentences talking about your game to our #ship channel:)

@LucasHT22 LucasHT22 merged commit cfa8e0e into hackclub:main Dec 21, 2023
2 of 3 checks passed
LucasHT22 added a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
submission Game submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants