Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usb Converter #1163

Merged
merged 24 commits into from
Oct 16, 2024
Merged

Usb Converter #1163

merged 24 commits into from
Oct 16, 2024

Conversation

Alecsis
Copy link
Contributor

@Alecsis Alecsis commented Oct 8, 2024

Submission Checklist:

  • I am a current high school, middle school, or home schooled student.

  • I have joined the #electronics channel on Slack

  • I made this board from scratch, even if I followed a tutorial

  • I have followed the directions in README.md

    • Created a folder under onboard/projects
    • Filled out TEMPLATE.md as README.md inside your project folder
    • Uploaded gerber.zip and schematic.pdf inside your project folder
    • Created a folder called src and uploaded design files
    • Uploaded screenshot of PCB order called cart.png with all costs included
    • I am ordering the smallest batch size (ie. JLCPCB's smallest order is for 5 boards)
    • If outside the US I've checked that I can afford the customs charges in my country (which isn't covered by the grant)
  • (Optional) This project is from a tutorial1.

  • (Optional) This project is for OnBoard Live2.

  • (Optional) This project is for Trick or Trace3.

  • (Optional) I'm in a FIRST (FRC, FTC, FLL, etc.) team. The number is: ____

Footnotes

  1. Projects from a tutorial are 100% fine! We just want to ask so we can count how people are using tutorials.

  2. OnBoard Live is a special version of OnBoard where you can earn more money for designing advanced boards. Check out the #onboard-live channel on our Slack!

  3. Trick or Trace is a limited time design contest for PCBs, enter your PCB into one of the three catagories and by peer voting, get chosen for a 100$ additional grant from OnBoard.

@github-actions github-actions bot added the Submission New Boards! label Oct 8, 2024
@prophetorpheus
Copy link
Collaborator

prophetorpheus commented Oct 8, 2024

Hi, I'm Orpheus Leap! Here to help you review your PR.

projects/Type C to Type A Adapter!:

Required files

README.md A description of your project
cart.png cart.png
gerber.zip
schematic.pdf Manually check schematic.pdf
Source files - EasyEDA Found both PCB and SCH files

You can view a render of your board over on gerber.zip/2d!

Happy OnBoarding!
This bot is a simpler helper for common submission types. If there's an error with this, please point it out and someone from the OnBoard team will look at it manually.

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 8, 2024

The latest commit is my USB converter PCB for the trick or treat event

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 8, 2024

trace mb!

@LimesKey LimesKey self-assigned this Oct 11, 2024
Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're trying to commit two projects, are you able to create a separate pull request for each project?

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 11, 2024

No, the other project should be merged

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 11, 2024

Like the other one was my other 50$ for a non tutorial

@LimesKey
Copy link
Collaborator

LimesKey commented Oct 11, 2024

They're both for Trick or Trace? We have automations that don't work when you try to submit two projects in one pull request.

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 11, 2024

wait there should be only one project that is being submitted, I can't see the other one. Can you tell me what's the other project?

@LimesKey
Copy link
Collaborator

image

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 11, 2024

Type a to c should be merged but can you delete it?

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 12, 2024

okay should be good, i deleted the directory

Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Alecsis,

Thanks for submitting your PCB pull request for OnBoard! However, it looks like you took a picture of the cart ordering process instead of completing the checkout process. For us to have the full picture of pricing and the PCB your ordering, please follow the steps in this guide here or here:

  1. Click "Secure Checkout": After adding your PCB to the cart
  2. Enter your shipping information and add a coupon code if you have one, then click "Submit Order", do not add any payment options
  3. Close that tab and open a new one to jlcpcb.com, then click "Order History" and take a screenshot. It should show all the details of your order.

Please take a screenshot of your unpaid order instead of a picture of your cart, and upload it as cart.png. This will allow us to spot any mistakes and give you ways to reduce the cost or customs fee. Congrats on making the PCB!

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 14, 2024

Should be updated

@Alecsis Alecsis requested a review from LimesKey October 14, 2024 20:19
Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your Trick or Trace submission but do you think you can re-complete the verification form so that we can send you some stickers in the mail?

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 15, 2024

Yea, all good! I filled it out

Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great submissions, going to approve it, but I'm a little confused on how your board looks in the gerber viewer? It seems very different compared to the schematic.pdf you submitted.

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 16, 2024

Oh shoot, I accidentally submitted another schematic that I was referencing to for the hackpad project, I'm going to reupload it

@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 16, 2024

K should be good

Copy link
Collaborator

@LimesKey LimesKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Alecsis!

Thanks for submitting your design to Trick or Trace! Project voting open Oct 21st, check in to #electronics (in the Slack) or on the website for the link to see your project in the gallery, and to vote on other's designs. Look forward to receiving a small package in the mail in the next few weeks, just a small gift to continue you on your journey of making.

@LimesKey LimesKey merged commit f3e6629 into hackclub:main Oct 16, 2024
3 checks passed
@Alecsis
Copy link
Contributor Author

Alecsis commented Oct 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants