Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFP-1884 don't impose align:center #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucaboesch
Copy link

@otacke
Copy link
Contributor

otacke commented Jun 29, 2021

@lucaboesch Just removing the CSS value would very likely change the behavior of existing content after updating.

If people got used to the bug (as I did), they would not click on the center button anymore but rely on content being centered either way. If you now just take away that styling, the text would be left aligned.

I think In addition you should also have to take care of existing contents first by updating them via H5P's upgrade mechanism. You could center them for real in HTML. This way, people could change the alignment to left or right themselves if they want to by editing the content after the upgrade - but their existing content will not break forcing them to manually change everything back to centered.

I have done the same for Dialogcards in case you want to see a reference: https://github.com/h5p/h5p-dialogcards/pull/96/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants