-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HFP-3715 Make card contents more flexible #86
base: master
Are you sure you want to change the base?
Conversation
otacke
commented
Jan 6, 2021
- Allows the author to set every page of a card individually:
- text and/or
- image and/or
- audio
- Keeps current page setup as default.
- Updates existing content to new semantics.
This is awesome! |
Amazing!!! Thanks a lot! |
72e2d43
to
23ac423
Compare
hello. Can I copy and paste this in somewhere and it will work? Or is it still in progress? if so. where do i copy and paste . is there a tutorial. thanks |
0532916
to
8453069
Compare
@Profedeespanol You can use this code in theory. It has been running successfully on a custom H5P platform for 1.5 years. One would just need to merge in this pull request (please refer to any git[hub] tutorial or maybe https://peter.baumgartner.name/2021/04/12/h5p-library-installation/ including the comments), rebuild the distribution files and install the library file. But, as long as the H5P core team doesn't accept this code and merges it into the official code, you'd be running a changed version with a different data structure. Not only would the code that you used be overwritten when you install an update, also your content that was created with this code would stop working. The ball is in the H5P core team's court, but from what I understand, they may lack some resources to take a look and either reject the pull request at all or to check and merge the code. |
8453069
to
f31a2a8
Compare
- Change editor structure to use separate groups for front and back - Make text, image and audio optional - Allow to set text, image and audio individually for front and back - Keep previous default logic (image for front and back, audio only front) - Create upgrade script for existing content - Update translations
f31a2a8
to
b0b48fd
Compare