Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFP-3715 Make card contents more flexible #86

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

otacke
Copy link
Contributor

@otacke otacke commented Jan 6, 2021

  • Allows the author to set every page of a card individually:
    • text and/or
    • image and/or
    • audio
  • Keeps current page setup as default.
  • Updates existing content to new semantics.

@mightyx
Copy link

mightyx commented Jun 30, 2021

This is awesome!

@katarad0
Copy link

Amazing!!! Thanks a lot!

@otacke otacke force-pushed the origin/KL-1461-backside-options branch from 72e2d43 to 23ac423 Compare December 22, 2021 12:15
@Profedeespanol
Copy link

hello. Can I copy and paste this in somewhere and it will work? Or is it still in progress?

if so. where do i copy and paste . is there a tutorial. thanks

@otacke otacke force-pushed the origin/KL-1461-backside-options branch from 0532916 to 8453069 Compare July 7, 2022 12:46
@otacke
Copy link
Contributor Author

otacke commented Jul 7, 2022

@Profedeespanol You can use this code in theory. It has been running successfully on a custom H5P platform for 1.5 years. One would just need to merge in this pull request (please refer to any git[hub] tutorial or maybe https://peter.baumgartner.name/2021/04/12/h5p-library-installation/ including the comments), rebuild the distribution files and install the library file.

But, as long as the H5P core team doesn't accept this code and merges it into the official code, you'd be running a changed version with a different data structure. Not only would the code that you used be overwritten when you install an update, also your content that was created with this code would stop working.

The ball is in the H5P core team's court, but from what I understand, they may lack some resources to take a look and either reject the pull request at all or to check and merge the code.

@otacke otacke force-pushed the origin/KL-1461-backside-options branch from 8453069 to f31a2a8 Compare December 29, 2022 14:13
otacke added 11 commits May 5, 2023 12:38
- Change editor structure to use separate groups for front and back
- Make text, image and audio optional
- Allow to set text, image and audio individually for front and back
- Keep previous default logic (image for front and back, audio only front)
- Create upgrade script for existing content
- Update translations
@otacke otacke force-pushed the origin/KL-1461-backside-options branch from f31a2a8 to b0b48fd Compare May 5, 2023 11:02
@otacke otacke changed the title Make card contents more flexible HFP-3715 Make card contents more flexible May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants