Fix Transmission piece bitmap creation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Marshal() function in BitArray returns a serialized representation of the BitArray object itself, which consists of much more than just the actual bit content : it starts with an identifier and two 64-bit integers. This caused the returned bit array to always contain some zeroes in the beginning, which were reported by GUI clients as missing pieces despite, for example, the torrent being completed. This commit replaces the bitarray usage with manually creating the bitmap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Marshal() function in BitArray returns a serialized representation of the BitArray object itself, which consists of much more than just the actual bit content : it starts with an identifier and two 64-bit integers. This caused the returned bit array to always contain some zeroes in the beginning, which were reported by GUI clients as missing pieces despite, for example, the torrent being completed.
This commit replaces the bitarray usage with manually creating the bitmap.