Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

Remove requestPredictionIntervals flag from scoring request #375

Closed
wants to merge 14 commits into from
Closed

Remove requestPredictionIntervals flag from scoring request #375

wants to merge 14 commits into from

Conversation

jackjii79
Copy link
Contributor

@jackjii79 jackjii79 commented Sep 6, 2023 •
edited
Loading

https://github.com/h2oai/mlops/issues/320

  • remove requestPredictionIntervals from score request API
  • Always compute prediction intervals whenever possible
  • pass output schema fields into response converter to ensure output schema always consistent with score response

@jackjii79 jackjii79 added enhancement New feature or request area/swagger labels Sep 6, 2023
@jackjii79 jackjii79 self-assigned this Sep 6, 2023
@jackjii79 jackjii79 force-pushed the issue-2196/remove-prediction-interval-api branch from e34c4e6 to 9c0fef7 Compare September 7, 2023 18:32
@jackjii79 jackjii79 force-pushed the issue-2196/remove-prediction-interval-api branch from 756cd71 to 7347396 Compare September 7, 2023 19:58
@jackjii79 jackjii79 requested a review from g-eoj September 7, 2023 19:59
@jackjii79 jackjii79 marked this pull request as ready for review September 7, 2023 19:59
g-eoj
g-eoj previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@g-eoj g-eoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@g-eoj g-eoj self-requested a review February 28, 2024 19:34
@jackjii79 jackjii79 dismissed g-eoj’s stale review August 26, 2024 08:05

The merge-base changed after approval.

@jakubhava
Copy link
Collaborator

Closing as stale

@jakubhava jakubhava closed this Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@g-eoj g-eoj Awaiting requested review from g-eoj

@Rupeekshan Rupeekshan Awaiting requested review from Rupeekshan Rupeekshan is a code owner

@shsma shsma Awaiting requested review from shsma shsma is a code owner

Assignees

@jackjii79 jackjii79

Labels
area/swagger enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackjii79 @jakubhava @g-eoj