Dynamically set capabilities endpoint based on configuration #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves #279 |
orendain
approved these changes
Jan 8, 2022
...rest-scorer/src/main/java/ai/h2o/mojos/deploy/local/rest/controller/ModelsApiController.java
Show resolved
Hide resolved
...rest-scorer/src/main/java/ai/h2o/mojos/deploy/local/rest/controller/ModelsApiController.java
Outdated
Show resolved
Hide resolved
orendain
approved these changes
Jan 11, 2022
...rest-scorer/src/main/java/ai/h2o/mojos/deploy/local/rest/controller/ModelsApiController.java
Outdated
Show resolved
Hide resolved
...rest-scorer/src/main/java/ai/h2o/mojos/deploy/local/rest/controller/ModelsApiController.java
Outdated
Show resolved
Hide resolved
...-scorer/src/test/java/ai/h2o/mojos/deploy/local/rest/controller/ModelsApiControllerTest.java
Outdated
Show resolved
Hide resolved
...-scorer/src/test/java/ai/h2o/mojos/deploy/local/rest/controller/ModelsApiControllerTest.java
Show resolved
Hide resolved
|
|
||
| private static void mockDummyPipeline() { | ||
| MojoPipeline dummyPipeline = | ||
| new DummyPipeline(TEST_UUID, MojoFrameMeta.getEmpty(), MojoFrameMeta.getEmpty()); |
There was a problem hiding this comment.
I wonder if our static mock troubles would be fixed if we moved the loadMojoPipelineFromFile() call in MojoScorer.java from static to the constructor.
There was a problem hiding this comment.
maybe... Seems like a bigger rework than I'm inclined to tackle at the moment.
| @BeforeAll | ||
| static void setup() { | ||
| System.setProperty("mojo.path", "src/test/resources/multinomial-pipeline.mojo"); | ||
| mockDummyPipeline(); |
There was a problem hiding this comment.
Doesn't look like the static mock session was closed. Not a big deal since the class is small and each test relies on this.
But for thoroughness, I'll share a couple of ways through this:
- Perform staticmock as part of a
try()at the place it's needed, which auto cleans up the mock after use. Example. - Save the mock to a static variable and close the session as part of a
@AfterAll.
...-scorer/src/test/java/ai/h2o/mojos/deploy/local/rest/controller/ModelsApiControllerTest.java
Outdated
Show resolved
Hide resolved
Thanks will fix and merge I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement to
/model/capabilitiesendpoint. No longer hardcoded. Pulls configuration from the scorer and uses that to set the response.