forked from objectionary/lints
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(objectionary#77): bytes-without-data lint
- Loading branch information
Showing
4 changed files
with
144 additions
and
0 deletions.
There are no files selected for viewing
46 changes: 46 additions & 0 deletions
46
src/main/resources/org/eolang/lints/critical/bytes-without-data.xsl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
The MIT License (MIT) | ||
Copyright (c) 2016-2024 Objectionary.com | ||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
The above copyright notice and this permission notice shall be included | ||
in all copies or substantial portions of the Software. | ||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. | ||
--> | ||
<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" id="bytes-without-data" version="2.0"> | ||
<xsl:output encoding="UTF-8" method="xml"/> | ||
<xsl:template match="/"> | ||
<defects> | ||
<xsl:apply-templates select="//o" mode="with-data"/> | ||
</defects> | ||
</xsl:template> | ||
<xsl:template match="o" mode="with-data"> | ||
<xsl:variable name="data" select="normalize-space(string-join(text(), ''))"/> | ||
<xsl:if test="($data eq '') and (@base = 'bytes' or @base = 'org.eolang.bytes')"> | ||
<defect> | ||
<xsl:attribute name="line"> | ||
<xsl:value-of select="if (@line) then @line else '0'"/> | ||
</xsl:attribute> | ||
<xsl:attribute name="severity">critical</xsl:attribute> | ||
<xsl:text>Objects with their @base attributes containing 'org.eolang.bytes' must contain data, while "</xsl:text> | ||
<xsl:value-of select="@name"/> | ||
<xsl:text>" object does not</xsl:text> | ||
</defect> | ||
</xsl:if> | ||
</xsl:template> | ||
</xsl:stylesheet> |
28 changes: 28 additions & 0 deletions
28
src/main/resources/org/eolang/motives/critical/bytes-without-data.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# Bytes Without Data | ||
|
||
Each object `<o/>` in [XMIR], with its base containing `org.eolang.bytes` must | ||
have text data inside. | ||
|
||
Incorrect: | ||
|
||
```xml | ||
<program> | ||
<objects> | ||
<o name="bar" base="foo"/> | ||
</objects> | ||
</program> | ||
``` | ||
|
||
Correct: | ||
|
||
```xml | ||
<program> | ||
<objects> | ||
<o name="bar" base="foo"> | ||
A1-B2-C3-D4-E5 | ||
</o> | ||
</objects> | ||
</program> | ||
``` | ||
|
||
[XMIR]: https://news.eolang.org/2022-11-25-xmir-guide.html |
37 changes: 37 additions & 0 deletions
37
src/test/resources/org/eolang/lints/packs/bytes-without-data/allows-bytes-with-data.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# The MIT License (MIT) | ||
# | ||
# Copyright (c) 2016-2024 Objectionary.com | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included | ||
# in all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
--- | ||
sheets: | ||
- /org/eolang/lints/critical/bytes-without-data.xsl | ||
asserts: | ||
- /defects[count(defect[@severity='critical'])=0] | ||
document: | | ||
<program> | ||
<objects> | ||
<o name="foo" base="org.eolang.bytes"> | ||
A1-B2-C3-D4-E5 | ||
</o> | ||
<o name="xyz" base="bytes"> | ||
привет, дорогой! | ||
</o> | ||
</objects> | ||
</program> |
33 changes: 33 additions & 0 deletions
33
src/test/resources/org/eolang/lints/packs/bytes-without-data/catches-bytes-without-data.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# The MIT License (MIT) | ||
# | ||
# Copyright (c) 2016-2024 Objectionary.com | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included | ||
# in all copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
--- | ||
sheets: | ||
- /org/eolang/lints/critical/bytes-without-data.xsl | ||
asserts: | ||
- /defects[count(defect[@severity='critical'])=2] | ||
document: | | ||
<program> | ||
<objects> | ||
<o name="foo" base="org.eolang.bytes"/> | ||
<o name="xyz" base="bytes"/> | ||
</objects> | ||
</program> |