Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cursive work with ncurses v6.0.1 #778

Merged
merged 3 commits into from
Jul 12, 2024

Commits on Jul 12, 2024

  1. make it work with ncurses-rs >=6.0.1

    which means that ncurses-rs already has the
    needed changes in this PR:
    jeaye/ncurses-rs#220
    and/or from this PR:
    jeaye/ncurses-rs#218
    correabuscar committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d4247f8 View commit details
    Browse the repository at this point in the history
  2. get rid of a warning when using newterm

    newterm https://github.com/jeaye/ncurses-rs/blob/3aa22bc279e4929e3ab69d49f75a18eda3e431e9/src/lib.rs#L1023-L1029
    CString::new https://doc.rust-lang.org/std/ffi/struct.CString.html#method.new
    
    bubble up this newterm error
    
    as suggested here: gyscos#778 (comment)
    
    Co-authored-by: Alexandre Bury <[email protected]>
    
    preserve original error in the panic report
    
    otherwise, we'd not know why ncurses-rs newterm errored
    
    directly include the variable name in the format! expression
    
    as suggested here: gyscos#778 (comment)
    
    Co-authored-by: Alexandre Bury <[email protected]>
    correabuscar and gyscos committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c02de5b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0bd373d View commit details
    Browse the repository at this point in the history