Fix Freedesktop shortcuts not using the page title for Name and Title

#54
gyng · Jan 28, 2018 · 762b0fc · 762b0fc
1 parent 70229dc
commit 762b0fc
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 2.4.1
+
+* Fix Freedesktop shortcuts not using the page title for Name and Title (#54)
+
 # 2.4.0
 
 * Major refactor to options management, downloading, and renaming. I've tried to keep behaviour identical to older versions so if there are any unexpected changes please file an issue. The extension has had insane feature creep and code spaghettification, so this taming was necessary to keep it maintainable.

diff --git a/manifest.json b/manifest.json
@@ -2,7 +2,7 @@
   "manifest_version": 2,
   "name": "__MSG_extensionName__",
   "description": "__MSG_extensionDescription__",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "default_locale": "en",
 
   "applications": {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "save-in",
-  "version": "2.3.1",
+  "version": "2.4.1",
   "license": "MIT",
   "scripts": {
     "build": "env -u WEB_EXT_API_KEY -u WEB_EXT_API_SECRET web-ext build --overwrite-dest -i test docs yarn.lock",

diff --git a/src/shortcut.js b/src/shortcut.js
@@ -33,7 +33,7 @@ const Shortcut = {
 
   makeShortcut: (type, url) =>
     Download.makeObjectUrl(
-      Shortcut.makeShortcutContent(type, url, currentTab.pageTitle)
+      Shortcut.makeShortcutContent(type, url, currentTab.title)
     ),
 
   suggestShortcutFilename: (