Check download origin before suggesting new filename in Chrome

#109
gyng · Apr 27, 2019 · 00ca8b8 · 00ca8b8
1 parent 0b3cc13
commit 00ca8b8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 # 3.4.1
 
 * Fix `Referer` header not set in Chrome >= 72 (#66)
+* Check if download originates from save-in before renaming download (Chrome, #109)
+* Add favicon to options page (#108)
 
 # 3.4.0
 

diff --git a/src/download.js b/src/download.js
@@ -199,10 +199,17 @@ if (chrome && chrome.downloads && chrome.downloads.onDeterminingFilename) {
         (globalChromeState.info && globalChromeState.info.suggestedFilename) ||
         downloadItem.filename ||
         (globalChromeState.info && globalChromeState.info.filename);
-      suggest({
-        filename: Download.finalizeFullPath(globalChromeState),
-        conflictAction: options.conflictAction
-      });
+
+      // Don't interfere with other extensions
+      if (
+        browser.runtime &&
+        browser.runtime.id === downloadItem.byExtensionId
+      ) {
+        suggest({
+          filename: Download.finalizeFullPath(globalChromeState),
+          conflictAction: options.conflictAction
+        });
+      }
     }
   );
 }