-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Hound #18
base: master
Are you sure you want to change the base?
Test Hound #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.eslintrc:
.eslintrc: Configuration for rule "react/no-deprecated" is invalid: Value [{"react":"0.14.6"}] should NOT have more than 0 items.Error: .eslintrc:
at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:507:19)
at Object.load (/app/node_modules/eslint/lib/config/config-file.js:550:20)
at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:228:44)
at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)
at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:287:21)
@@ -0,0 +1,4 @@ | |||
x = 1 | |||
if x == 1: | |||
print("x is 1.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is not a multiple of four
@@ -0,0 +1,4 @@ | |||
x = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IndentationError: unexpected indent
unexpected indentation
defmodule Test do | ||
|
||
def print(foo,bar) do | ||
IO.puts(foo, bar) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no trailing white-space at the end of a line.
@@ -0,0 +1,6 @@ | |||
defmodule Test do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modules should have a @moduledoc tag.
@@ -0,0 +1,6 @@ | |||
defmodule Test do | |||
|
|||
def print(foo,bar) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space missing after comma
LOGISTICS = [NAME, VERSION].freeze | ||
|
||
def foo | ||
puts 'bar' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
# Test Hound | ||
class TestHound | ||
NAME = 'Wormbots' | ||
VERSION = '0.0.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
@@ -0,0 +1,3 @@ | |||
* Hello |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect list-item indent: add 2 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.eslintrc:
.eslintrc: Configuration for rule "react/no-deprecated" is invalid: Value [{"react":"0.14.6"}] should NOT have more than 0 items.Error: .eslintrc:
at validateRuleOptions (/home/linters/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:507:19)
at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)
at Config.getConfigVector (/home/linters/node_modules/eslint/lib/config.js:287:21)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.eslintrc:
.eslintrc: Configuration for rule "react/no-deprecated" is invalid: Value [{"react":"0.14.6"}] should NOT have more than 0 items.Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)
x = 1 | ||
if x == 1: | ||
print("x is 1.") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line at end of file
|
||
# Test Hound | ||
class TestHound | ||
NAME = 'Wormbots' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.eslintrc:
.eslintrc: Configuration for rule "react/no-deprecated" is invalid: Value [{"react":"0.14.6"}] should NOT have more than 0 items.Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.eslintrc:
.eslintrc: Configuration for rule "react/no-deprecated" is invalid: Value [{"react":"0.14.6"}] should NOT have more than 0 items.Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)
No description provided.