Fix Psi4 load #65
Closed
Fix Psi4 load #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove tgz v2 copy
prayush
reviewed
Dec 20, 2024
Comment on lines
+220
to
+222
| wftools_modes_array = load_RIT_Psi4_data_from_disk( | ||
| data_file_path=file_path, output_modes_array=True, resam_type="finest" | ||
| ) |
There was a problem hiding this comment.
Lets not delegate this IO task to another package. Offloading minor math operations is fine, but this functionality is central to the nr-catalog-tools package to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple issues were found with existing Psi4 load. Was taking time to fix all.
The core of the load is now delegated to waveformtools. Tested and working.
FFI coming up next