-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support of buf_redux / streaming input #26
Conversation
Some rustdoc is not up to date like here but I will fix them later... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Actually, there is a drawback to this, the scanner is not allowed to own its buffer. This is an issue when you want to store the parser |
I think we should let the scanner own the buffer and add store an offset to the current byte position, instead of re-slicing. The buffer can be made generic over |
This solution should also help fixing #4 |
With
I should be able to fix |
I had to do the contrary in 611b94f: the input is now passed as a parameter to the |
Should fix #21 and #23