This repository has been archived by the owner on May 30, 2024. It is now read-only.
Fix the test suite #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test contained a Python 2 print statement with no brackets. Also took the opportunity to simplify the tests and stop pytest complaining.
Fix failing tests by changing the PyxlParser to use the str method instead of the deprecated unicode method when parsing HTML attributes.
Rewrite tests/test_basic.py to be more similar to the other test files in the test directory. Instead of using unittest, tests are just asserts in functions that can be run by pytest.
Rewrite tests/test_rss.py to be more similar to the other test files in the test directory. Instead of using unittest, tests are just asserts in functions that can be run by pytest.
|
You're welcome to maintain a fork and promote it, but I have no time to be
involved, sorry.
|
|
No worries at all. Thanks for getting back to me. Should I assume you won't be reviewing or accepting this PR and your fork is basically 'unmaintained'? |
|
Correct.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the current README, there is no documented way of running the full test suite. In fact there's never been a script for running the full suite: what happened is that the original script pyxl_tests.py was renamed and then more tests were added but without any instructions.
This PR aims to fix that, plus a few other problems:
META:
This PR is being made from an organisation called
pyxl3that I created specifically to make these changes. I had to do this because I already made a similar PR to the originalpyxllink and GitHub wouldn't let me then fork your fork whilst having a fork of the originalpyxlat the same time (ugh).However, this might present an opportunity to improve the contributor experience for this project. @gvanrossum would you be happy if the repo at pyxl3/pyxl3 becomes the 'official' Python 3 port of
pyxl3? You can, of course, be a full admin member of this organisation. I would then request with GitHub to turn the repo from a fork to a standalone repo.The motivation on my side is that I would like to give this project some 'love'. Here are some ways I'd like to work on improving it:
pyxlproject, eg linkpip install pyxl3instead of cloning from GitHub.