Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_requires = setuptools; python_version>="3.12" and upgrade GitHub Actions #24

Merged
merged 7 commits into from
Sep 7, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 15, 2024

@cclauss cclauss changed the title Upgrade GitHub Actions install_requires = setuptools; python_version>="3.12" and upgrade GitHub Actions Apr 17, 2024
@dbarnett
Copy link

Also fixes so you can successfully install it with pipx and run it. =)

Would be great to get this merged!

@cclauss
Copy link
Contributor Author

cclauss commented Aug 24, 2024

@dbarnett When you think a pull request is useful and is ready to be merged, please consider giving it a positive review.

Every check mark ✔️ at the top right of this page gives project maintainers confidence that the proposed changes have been read through and deemed both useful and safe to merge into the codebase. Lots of 👍 and "what is the ETA?" comments are easier for maintainers to ignore than ✔️✔️✔️✔️✔️ from several different reviewers.

Anyone can review a pull request on GitHub. To do so here:

  1. Scroll to the top of this page.
  2. Click the Files changed tab and read through each file carefully looking for potential issues.
  3. Click the Review changes button.
  4. Click Approve (or one of the other options) and add comments only if they have not already been stated in the PR.
  5. Click Submit review so that your ✔️ will be added to the list.

@gvalkov gvalkov merged commit 3fe97e4 into gvalkov:master Sep 7, 2024
1 check passed
@gvalkov
Copy link
Owner

gvalkov commented Sep 7, 2024

Thanks for the fix and sorry for the terrible delay.

@cclauss cclauss deleted the patch-3 branch September 7, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work when __name__ == __main__ Exception raised when a command is imported in setup.py
3 participants