Adding a test for both out of order and race condition, fixing GetItem for OOO #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the library!
I noticed there was a problem where if the test suite calls out of order from the order that the expectations were set then we'd get different behavior.
This works off of what was added for BatchWriteItem in #16. Note that this could be considered backwards incompatible because the errors that are returned are different, if we are considering the entire list of expectations then we can't necessarily return as nice of errors.
Additionally I suspected that we would be getting a race condition where expectations aren't properly removed. This is fixed by introducing a mutex.