Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upon error, return a pointer to a blank output object, not nil. #35

Merged
merged 15 commits into from
Jan 7, 2021
Merged

Upon error, return a pointer to a blank output object, not nil. #35

merged 15 commits into from
Jan 7, 2021

Conversation

danny-cheung
Copy link
Contributor

Fixes issue #34

@gusaul
Copy link
Owner

gusaul commented Jan 6, 2021

please resolve the conflict

@danny-cheung
Copy link
Contributor Author

Fixes test failures created by PR #25

@danny-cheung
Copy link
Contributor Author

@gusaul Merge conflicts resolved.

Also fixed up the build tests.

@gusaul gusaul merged commit 6ce2cee into gusaul:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danny-cheung @gusaul