Add short tag name option for nested tag helpers #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunndabad
force-pushed
the
short-tag-names
branch
from
890a96c to
5d7ad5c
Compare
gunndabad
changed the title
gunndabad
force-pushed
the
short-tag-names
branch
2 times, most recently
from
ce9bc47 to
fed078b
Compare
|
@sussexrick for info. If this lands the docs will likely switch to recommending the short form of the tag names. |
gunndabad
force-pushed
the
short-tag-names
branch
from
fed078b to
c573a71
Compare
|
Thanks for the heads-up. As you're supporting both the short-form and long-form names it's a non-breaking change and I don't see it being a problem for us. Nice idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tag names are extremely long and unnecessarily verbose. For tag helpers that are constrained to a parent we could offer a short option without its meaning being ambiguous.