Update to govuk-frontend 5.1.0

gunndabad · Mar 6, 2024 · f21ef39 · f21ef39
1 parent dc0ec40
commit f21ef39
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -4,7 +4,7 @@
     <TreatWarningsAsErrors Condition="'$(Configuration)' == 'Release'">true</TreatWarningsAsErrors>
     <RepoRoot>$([MSBuild]::EnsureTrailingSlash('$(MSBuildThisFileDirectory)'))</RepoRoot>
     <Nullable>enable</Nullable>
-    <GovUkFrontendVersion>5.0.0</GovUkFrontendVersion>
+    <GovUkFrontendVersion>5.1.0</GovUkFrontendVersion>
 
     <_NpmLibDirectory>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'lib'))</_NpmLibDirectory>
     <_NpmLibVersionFile>$([System.IO.Path]::Combine('$(_NpmLibDirectory)', 'version.txt'))</_NpmLibVersionFile>

diff --git a/src/GovUk.Frontend.AspNetCore/HtmlGeneration/ComponentGenerator.Accordion.cs b/src/GovUk.Frontend.AspNetCore/HtmlGeneration/ComponentGenerator.Accordion.cs
@@ -140,7 +140,6 @@ public TagBuilder GenerateAccordion(
             var contentDiv = new TagBuilder("div");
             contentDiv.MergeCssClass("govuk-accordion__section-content");
             contentDiv.Attributes.Add("id", contentId);
-            contentDiv.Attributes.Add("aria-labelledby", headingId);
             contentDiv.MergeOptionalAttributes(item.ContentAttributes);
             contentDiv.InnerHtml.AppendHtml(item.Content);
             section.InnerHtml.AppendHtml(contentDiv);

diff --git a/test/GovUk.Frontend.AspNetCore.Tests/TagHelpers/AccordionTagHelperTests.cs b/test/GovUk.Frontend.AspNetCore.Tests/TagHelpers/AccordionTagHelperTests.cs
@@ -67,7 +67,7 @@ public async Task ProcessAsync_GeneratesExpectedOutput()
             </h1>
             <div class=""govuk-body govuk-accordion__section-summary"" id=""testaccordion-summary-1"">First summary</div>
         </div>
-        <div aria-labelledby=""testaccordion-heading-1"" class=""govuk-accordion__section-content"" id=""testaccordion-content-1"">
+        <div class=""govuk-accordion__section-content"" id=""testaccordion-content-1"">
             First content
         </div>
     </div>
@@ -77,7 +77,7 @@ First content
                 <span class=""govuk-accordion__section-button"" id=""testaccordion-heading-2"">Second heading</span>
             </h1>
         </div>
-        <div aria-labelledby=""testaccordion-heading-2"" class=""govuk-accordion__section-content"" id=""testaccordion-content-2"">
+        <div class=""govuk-accordion__section-content"" id=""testaccordion-content-2"">
             First content
         </div>
     </div>
@@ -146,7 +146,7 @@ public async Task ProcessAsync_WithSectionTranslationAttributes_GeneratesExpecte
             </h2>
             <div class=""govuk-body govuk-accordion__section-summary"" id=""testaccordion-summary-1"">First summary</div>
         </div>
-        <div aria-labelledby=""testaccordion-heading-1"" class=""govuk-accordion__section-content"" id=""testaccordion-content-1"">
+        <div class=""govuk-accordion__section-content"" id=""testaccordion-content-1"">
             First content
         </div>
     </div>
@@ -156,7 +156,7 @@ First content
                 <span class=""govuk-accordion__section-button"" id=""testaccordion-heading-2"">Second heading</span>
             </h2>
         </div>
-        <div aria-labelledby=""testaccordion-heading-2"" class=""govuk-accordion__section-content"" id=""testaccordion-content-2"">
+        <div class=""govuk-accordion__section-content"" id=""testaccordion-content-2"">
             First content
         </div>
     </div>