feat(client): application migrations #602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chose to pass a query runner rather than using repositories as after new features/refactors, previously used repositories may not exist anymore breaking backwards compatibility. Using the query runner, this will not happen. Since the migrations are bound in the DI container, dependencies can still be injected in them if necessary. |
guidojw
commented
Oct 5, 2023
| return target.apply(thisArgument, [...argumentsList, dataSource.createQueryRunner()]) | ||
| } | ||
| } | ||
| if (typeof migration.shouldRun !== 'undefined') { |
| @@ -132,6 +137,14 @@ export default class AroraClient<Ready extends boolean = boolean> extends Client | |||
| return usedToken | |||
| } | |||
|
|
|||
| private async runMigrations (): Promise<void> { | |||
| for (const migration of this.migrations) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an application migrations system in the code, useful for e.g. migrating Discord resources after the database migrations have run.
Added an activation handler on the new migration service identifier that automatically passes a query runner to the migrations, so that the client does not have to instance one.