-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitAuto: [FEATURE] Implement SKU Seller API #395
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Infisical secrets check: ✅ No secrets leaked! 💻 Scan logs12:11AM INF scanning for exposed secrets...
12:11AM INF 347 commits scanned.
12:11AM INF scan completed in 291ms
12:11AM INF no leaks found
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonarcsharp (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
❌ Build VTEX-SDK-dotnet 2.4.241 failed (commit e4c11a74b8 by @gitauto-ai[bot]) |
Resolves #30
What is the feature
Implement the SKU Seller API, enabling the consultation and deletion of SKU Sellers. An SKU Seller represents a seller associated with a specific SKU within the catalog.
Why we need the feature
This feature allows sellers and developers to programmatically manage SKU Sellers, facilitating better control over product listings and seller associations. By providing API endpoints for consulting and deleting SKU Sellers, we enhance the flexibility and scalability of the catalog management system.
How to implement and why
Design API Endpoints: Develop RESTful endpoints for retrieving and deleting SKU Sellers in accordance with the SKU Seller documentation.
Model Development: Create or update the SKU Seller models to accurately represent the relationship between SKUs and sellers.
Controller Logic: Implement controller methods to handle API requests for consulting and deleting SKU Sellers, ensuring proper validation and error handling.
Routing Configuration: Define the necessary routes that map HTTP requests to the corresponding controller methods for the SKU Seller operations.
Integration with Existing Systems: Ensure that the new API integrates seamlessly with the existing catalog and seller management systems.
Testing: Write comprehensive unit and integration tests to verify the functionality and reliability of the SKU Seller API endpoints.
Documentation: Update the API documentation to include the new SKU Seller endpoints, referencing this article for additional context and usage guidelines.
This structured approach ensures that the SKU Seller API is robust, maintainable, and aligns with the overall system architecture, providing a reliable tool for managing seller associations with SKUs.
About backward compatibility
Since this feature introduces new API endpoints without modifying existing functionality, there are no backward compatibility concerns. Existing integrations and workflows will remain unaffected.
Test these changes locally