-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitAuto: [FEATURE] Implement SKU Kit API #335
GitAuto: [FEATURE] Implement SKU Kit API #335
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
✅ Build VTEX-SDK-dotnet 2.3.1181 completed (commit dd65f9e3a7 by @code-factor) |
Infisical secrets check: ✅ No secrets leaked! 💻 Scan logs11:39AM INF scanning for exposed secrets...
11:39AM INF 526 commits scanned.
11:39AM INF scan completed in 276ms
11:39AM INF no leaks found
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sonarcsharp (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Quality Gate passedIssues Measures |
✅ Build VTEX-SDK-dotnet 2.4.19 completed (commit 732039e396 by @gstraccini[bot]) |
Resolves #29
What is the feature
This feature implements the SKU Kit API within the SDK, allowing users to consult, create, and update SKU Kits. A SKU Kit is an SKU composed of one or more other SKUs, functioning as a bundled product. By integrating this API, users can manage SKU Kits directly through the SDK.
Why we need the feature
Implementing the SKU Kit API enhances the SDK's capabilities by supporting the full range of VTEX catalog functionalities. Businesses that offer product bundles rely on SKU Kits to manage inventory and sales efficiently. By providing this feature, we enable developers to create more complex product offerings and streamline their catalog management processes.
How to implement and why
Review the VTEX SKU Kit API Documentation:
Define Data Models for SKU Kits:
SkuKit
,SkuKitItem
, etc.) in theSrc
directory to represent SKU Kits and their components accurately.Id
,Quantity
,SkuComponents
) are included to match the API specifications.Implement API Client Methods:
GetSkuKit(int skuId)
: Retrieve the details of an existing SKU Kit.CreateSkuKit(SkuKit kit)
: Create a new SKU Kit.UpdateSkuKit(int skuId, SkuKit kit)
: Update an existing SKU Kit.Src
directory, such asSkuKitService
.Handle Authentication and Authorization:
Implement Error Handling and Logging:
Write Unit and Integration Tests:
Tests
directory.Update Documentation and Examples:
README.md
and any relevant markdown files in thedocs
directory to reflect these changes.Ensure Code Consistency and Style Compliance:
.csharpierrc.yaml
.Why:
About backward compatibility
Introducing the SKU Kit API is an additive change that does not modify or remove existing functionalities. It maintains backward compatibility because:
Therefore, the addition enhances the SDK without introducing any breaking changes.
Test these changes locally