Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump csharpier from 0.28.2 to 0.29.1 #292

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Bumps csharpier from 0.28.2 to 0.29.1.

Release notes

Sourced from csharpier's releases.

0.29.1

What's Changed

Sorting of usings with underscore differs from Visual Studio #1327

CSharpier now sorts _ to the bottom of usings.

using SomeCompany.MWord;
using SomeCompany.ZWord;
using SomeCompany._Word;

Process cannot access the file "....net8.0\any\server.log" while running multiple extensions. #1324

CSharpier Server now uses a log file name based on the port that it is starting on to avoid concurrency issues trying to access the same log file

Full Changelog: belav/csharpier@0.29.0...0.29.1

0.29.0

Breaking Changes

The formatting command will now exit with an error code of 1 if one of the target files cannot be compiled #1131

Prior to 0.29.0 if csharpier encountered a file that could not be compiled it would treat it as a warning and exit with a code of 0.
As of 0.29.0 a file that cannot be compiled is now treated as an error and csharpier will exit with code 1

What's Changed

Enforce trailing commas in object and collection initializer #668

CSharpier will now add trailing commas automatically where appropriate. It will collapse to a single line and remove the trailing comma in cases where everything fits on one line.

// input
public enum SomeEnum
{
    Value1,
    Value2
}
string[] someArray = new string[]
{
someLongValue_____________________________________________,
someLongValue_____________________________________________
};
string[] someArray = new string[]
{
someValue,
someValue,
};
// 0.29.0
public enum SomeEnum
{
Value1,
Value2,
}
</tr></table>

... (truncated)

Changelog

Sourced from csharpier's changelog.

# 0.29.1

What's Changed

Sorting of usings with underscore differs from Visual Studio #1327

CSharpier now sorts _ to the bottom of usings.

using SomeCompany.MWord;
using SomeCompany.ZWord;
using SomeCompany._Word;

Process cannot access the file "....net8.0\any\server.log" while running multiple extensions. #1324

CSharpier Server now uses a log file name based on the port that it is starting on to avoid concurrency issues trying to access the same log file

Full Changelog: belav/csharpier@0.29.0...0.29.1

0.29.0

Breaking Changes

The formatting command will now exit with an error code of 1 if one of the target files cannot be compiled #1131

Prior to 0.29.0 if csharpier encountered a file that could not be compiled it would treat it as a warning and exit with a code of 0.
As of 0.29.0 a file that cannot be compiled is now treated as an error and csharpier will exit with code 1

What's Changed

Enforce trailing commas in object and collection initializer #668

CSharpier will now add trailing commas automatically where appropriate. It will collapse to a single line and remove the trailing comma in cases where everything fits on one line.

// input
public enum SomeEnum
{
    Value1,
    Value2
}
string[] someArray = new string[]
{
someLongValue_____________________________________________,
someLongValue_____________________________________________
};
string[] someArray = new string[]
{
someValue,
someValue,
};
// 0.29.0
public enum SomeEnum
{
Value1,
Value2,
}
string[] someArray = new string[]
</tr></table>

... (truncated)

Commits
  • b87b4df Releasing 0.29.1 (#1331)
  • 10e0780 Support for multiple csharpier servers running at the same time, have them wr...
  • 2ed8622 Getting _ to sort to the top like it should (#1328)
  • 688aeb7 VS - Use dotnet tool list to find both local and global installs of csharpier...
  • 1cdcf0a fix width
  • c529570 prettier all the java
  • 88383e7 Using dotnet tool list for rider extension (#1325)
  • 2456512 Modify VSCode extension to use dotnet tool list + only warn to instal… (#1323)
  • 6cb3821 Format with 29 (#1322)
  • 0abbc1d fix typo
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file nuget Refers to nuget packages packages Packages labels Aug 26, 2024
@dependabot dependabot bot requested a review from guibranco August 26, 2024 01:18
@guibranco guibranco enabled auto-merge (squash) August 26, 2024 01:18
@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Aug 26, 2024
Copy link
Owner

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Aug 26, 2024
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2024
@guibranco
Copy link
Owner

@dependabot squash and merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 26, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Copy link

codacy-production bot commented Aug 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (78b407c) 1774 4 0.23%
Head commit (1340a95) 1774 (+0) 4 (+0) 0.23% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#292) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@AppVeyorBot
Copy link

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 0.22%. Comparing base (e63eb16) to head (b63975c).
Report is 1 commits behind head on main.

Files Patch % Lines
Src/VTEX/VTEXContext.cs 0.00% 4 Missing ⚠️
Src/VTEX/VTEXWrapper.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #292   +/-   ##
=====================================
  Coverage   0.22%   0.22%           
=====================================
  Files        117     117           
  Lines       1774    1774           
  Branches      75      75           
=====================================
  Hits           4       4           
+ Misses      1770    1768    -2     
- Partials       0       2    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bumps [csharpier](https://github.com/belav/csharpier) from 0.28.2 to 0.29.1.
- [Release notes](https://github.com/belav/csharpier/releases)
- [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md)
- [Commits](belav/csharpier@0.28.2...0.29.1)

---
updated-dependencies:
- dependency-name: csharpier
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/nuget/csharpier-0.29.1 branch from 5383bf6 to 5e335dc Compare August 26, 2024 02:16
@AppVeyorBot
Copy link

Build VTEX-SDK-dotnet 2.3.961 completed (commit 13aaf348a3 by @gstraccini[bot])

@AppVeyorBot
Copy link

Build VTEX-SDK-dotnet 2.3.968 completed (commit a872f990be by @gstraccini[bot])

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e63eb16) 1774 4 0.23%
Head commit (94fa374) 1774 (+0) 4 (+0) 0.23% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#292) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@AppVeyorBot
Copy link

Build VTEX-SDK-dotnet 2.3.978 completed (commit fd54735806 by @gstraccini[bot])

@guibranco
Copy link
Owner

@gstraccini csharpier

Copy link
Contributor

gstraccini bot commented Aug 27, 2024

Running CSharpier on this branch! 🔧

Copy link
Contributor

gstraccini bot commented Aug 27, 2024

CSharpier result:

Error ./Src/VTEX/Enums/RequestEndpoint.cs - Was not formatted.
  ----------------------------- Expected: Around Line 54 -----------------------------
          /// </summary>
          HEALTH,
      }
  ----------------------------- Actual: Around Line 54 -----------------------------
          /// </summary>
          HEALTH
      }
  
Error ./Src/VTEX/Enums/InvoiceType.cs - Was not formatted.
  ----------------------------- Expected: Around Line 36 -----------------------------
          [HumanReadable("Input")]
          INPUT,
      }
  ----------------------------- Actual: Around Line 36 -----------------------------
          [HumanReadable("Input")]
          INPUT
      }
  
Error ./Src/VTEX/VTEXWrapper.cs - Was not formatted.
  ----------------------------- Expected: Around Line 353 -----------------------------
                      {
                          Content = content,
                      };
  ----------------------------- Actual: Around Line 353 -----------------------------
                      {
                          Content = content
                      };
  
Error ./Src/VTEX/VTEXContext.cs - Was not formatted.
  ----------------------------- Expected: Around Line 114 -----------------------------
                  { @"page", @"0" },
                  { @"per_page", @"50" },
              };
  ----------------------------- Actual: Around Line 114 -----------------------------
                  { @"page", @"0" },
                  { @"per_page", @"50" }
              };
  
Error ./Src/VTEX/Enums/OrderStatus.cs - Was not formatted.
  ----------------------------- Expected: Around Line 126 -----------------------------
          [InternalValue("authorize-fulfillment")]
          AUTHORIZE_FULFILLMENT,
      }
  ----------------------------- Actual: Around Line 126 -----------------------------
          [InternalValue("authorize-fulfillment")]
          AUTHORIZE_FULFILLMENT
      }
  
Error ./Tests/VTEX.Tests/Health/VtexHealthClientTests.cs - Was not formatted.
  ----------------------------- Expected: Around Line 43 -----------------------------
                      Name = "Test",
                      LastResultStatus = "healthy",
                  },
  ----------------------------- Actual: Around Line 43 -----------------------------
                      Name = "Test",
                      LastResultStatus = "healthy"
                  },
  

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e63eb16) 1774 4 0.23%
Head commit (b63975c) 1774 (+0) 4 (+0) 0.23% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#292) 6 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

@AppVeyorBot
Copy link

Build VTEX-SDK-dotnet 2.3.980 completed (commit 760a6fa2bf by @)

@guibranco guibranco merged commit e38baad into main Aug 27, 2024
21 checks passed
@guibranco guibranco deleted the dependabot/nuget/csharpier-0.29.1 branch August 27, 2024 13:43
Copy link
Contributor

gstraccini bot commented Jan 11, 2025

I'm sorry @guibranco, I can't do that. This pull request is no longer open. ⛔

1 similar comment
Copy link
Contributor

gstraccini bot commented Jan 11, 2025

I'm sorry @guibranco, I can't do that. This pull request is no longer open. ⛔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations dependencies Pull requests that update a dependency file .NET Pull requests that update .net code nuget Refers to nuget packages packages Packages size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants