Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from CodeFactor #256

Merged
merged 2 commits into from
May 19, 2024
Merged

Apply fixes from CodeFactor #256

merged 2 commits into from
May 19, 2024

Conversation

codefactor-io[bot]
Copy link
Contributor

@codefactor-io codefactor-io bot commented May 19, 2024

This pull request applies style fixes from code review by CodeFactor.


For more information, click here.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 19, 2024
@gstraccini gstraccini bot requested a review from guibranco May 19, 2024 02:11
@guibranco
Copy link
Owner

@gstraccini csharpier

Copy link
Contributor

gstraccini bot commented May 19, 2024

Running CSharpier on this branch! 🔧

Copy link
Contributor

gstraccini bot commented May 19, 2024

CSharpier result:

Error ./Src/VTEX/Transport/Price.cs - Was not formatted.
  The file contained different line endings than formatting it would result in.

@guibranco guibranco linked an issue May 19, 2024 that may be closed by this pull request
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5186d3d) 1774 4 0.23%
Head commit (9fc17ec) 1774 (+0) 4 (+0) 0.23% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#256) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@AppVeyorBot
Copy link

Build VTEX-SDK-dotnet 2.3.781 completed (commit d8b926c1ca by @)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 0.22%. Comparing base (5186d3d) to head (9fc17ec).

Files Patch % Lines
Src/VTEX/VTEXContext.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #256   +/-   ##
=====================================
  Coverage   0.22%   0.22%           
=====================================
  Files        117     117           
  Lines       1774    1774           
  Branches      75      75           
=====================================
  Hits           4       4           
+ Misses      1770    1768    -2     
- Partials       0       2    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guibranco guibranco merged commit 15c75d2 into main May 19, 2024
23 of 25 checks passed
@guibranco guibranco deleted the main-cf-autofix branch May 19, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix CodeFactor issues
3 participants