Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributor): contributors readme action update #472

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Jul 28, 2024
@guibranco
Copy link
Owner

@gstraccini csharpier

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2024
Copy link
Contributor

gstraccini bot commented Jul 28, 2024

Running CSharpier on this branch! 🔧

Copy link
Contributor

gstraccini bot commented Jul 28, 2024

CSharpier result:

Error ./Src/CrispyWaffle.ElasticSearch/Helpers/Extensions.cs - Was not formatted.
  ----------------------------- Expected: Around Line 47 -----------------------------
          /// <returns>T.</returns>
          public static async Task<T> AliasAsync<T>(
              this T index,
  ----------------------------- Actual: Around Line 47 -----------------------------
          /// <returns>T.</returns>
          public static async Task<T> AliasAsync<T>(this T index, string alias, string indexName = null)
              where T : class, IIndexable, new()
  
Error ./Src/CrispyWaffle.ElasticSearch/Log/ElasticSearchLogProvider.cs - Was not formatted.
  ----------------------------- Expected: Around Line 96 -----------------------------
                  _indexName,
                  d =>
                      d.Query(q =>
  ----------------------------- Actual: Around Line 96 -----------------------------
                  _indexName,
                  d => d.Query(
                      q => q.Range(
  
Error ./Src/CrispyWaffle.ElasticSearch/Utils/Communications/ElasticWrapper.cs - Was not formatted.
  ----------------------------- Expected: Around Line 67 -----------------------------
              where T : class, IIndexable, new() =>
              _elastic
                  .GetAsync<T>(new GetRequest(Helpers.Extensions.GetIndexName<T>(), (Id)id))
  ----------------------------- Actual: Around Line 67 -----------------------------
              where T : class, IIndexable, new() =>
              _elastic.GetAsync<T>(new GetRequest(Helpers.Extensions.GetIndexName<T>(), (Id)id)).Result.Source;
  
  
Error ./Src/CrispyWaffle.ElasticSearch/Utils/Communications/ElasticConnector.cs - Was not formatted.
  ----------------------------- Expected: Around Line 24 -----------------------------
                  $"logs-{EnvironmentHelper.ApplicationName}-{EnvironmentHelper.Version}"
              ) { }
  
  ----------------------------- Actual: Around Line 24 -----------------------------
                  $"logs-{EnvironmentHelper.ApplicationName}-{EnvironmentHelper.Version}"
              )
          { }
  

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2024
Copy link
Contributor Author

Infisical secrets check: ✅ No secrets leaked!

Scan results:

3:06PM INF scanning for exposed secrets...
3:06PM INF 478 commits scanned.
3:06PM INF scan completed in 699ms
3:06PM INF no leaks found

public static async Task<T> AliasAsync<T>(
this T index,
string alias,
string indexName = null

Check warning

Code scanning / Sonarcsharp (reported by Codacy)

Use the overloading mechanism instead of the optional parameters. Warning

Use the overloading mechanism instead of the optional parameters.
new AddAction() { Index = indexName, Alias = alias }
)
aliases.Actions(actions =>
actions.Add(new AddAction() { Index = indexName, Alias = alias })

Check warning

Code scanning / Sonarcsharp (reported by Codacy)

Remove these redundant parentheses. Warning

Remove these redundant parentheses.
Copy link

sonarcloud bot commented Jul 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@guibranco guibranco merged commit 3073f77 into main Jul 28, 2024
22 of 26 checks passed
@guibranco guibranco deleted the contributors-readme-action-5ujMXGIyGX branch July 28, 2024 15:13
@AppVeyorBot
Copy link

Build CrispyWaffle 7.0.169 failed (commit 7d224506ab by @)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 bot Automated processes or integrations size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants