Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade elastic search dependencies #470

Merged
merged 7 commits into from
Jul 28, 2024
Merged

Upgrade elastic search dependencies #470

merged 7 commits into from
Jul 28, 2024

Conversation

Mohammad-Haris
Copy link
Contributor

Resolves #444

Before the change?

The project used deprecated dependencies:

Elasticsearch.Net
Nest

After the change?

Elastic search upgrade to: Elastic.Clients.Elasticsearch

Pull request checklist

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been reviewed and added/updated if needed (for bug fixes/features)

Does this introduce a breaking change?

  • Yes
  • No

P.S. We probably should add tests for the ElasticSearch project.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 28, 2024
@gstraccini gstraccini bot added 🛠 WIP Work in progress .NET Pull requests that update .net code dependencies Pull requests that update a dependency file 📝 documentation Tasks related to writing or updating documentation ElasticSearch enhancement New feature or request good first issue Good for newcomers hacktoberfest Participation in the Hacktoberfest event help wanted Extra attention is needed nuget packages labels Jul 28, 2024
@gstraccini gstraccini bot requested a review from guibranco July 28, 2024 08:38
@gstraccini gstraccini bot added the 🚦 awaiting triage Items that are awaiting triage or categorization label Jul 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Infisical secrets check: ✅ No secrets leaked!

Scan results:

2:53PM INF scanning for exposed secrets...
2:53PM INF 474 commits scanned.
2:53PM INF scan completed in 695ms
2:53PM INF no leaks found

@AppVeyorBot
Copy link

✅ Build CrispyWaffle 7.0.157 completed (commit 0383227254 by @guibranco)

@guibranco guibranco merged commit 5f72a13 into guibranco:main Jul 28, 2024
26 of 31 checks passed
@guibranco
Copy link
Owner

@Mohammad-Haris, great job on this pull request! Your changes significantly enhanced the functionality and clarity of our codebase.

Thank you for your excellent work!

@guibranco guibranco mentioned this pull request Jul 28, 2024
Merged
@Mohammad-Haris Mohammad-Haris deleted the upgrade-elastic-search-dependencies branch July 29, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gstraccini gstraccini[bot] gstraccini[bot] approved these changes

@guibranco guibranco guibranco approved these changes

Assignees

@guibranco guibranco

Labels
🚦 awaiting triage Items that are awaiting triage or categorization dependencies Pull requests that update a dependency file 📝 documentation Tasks related to writing or updating documentation ElasticSearch enhancement New feature or request good first issue Good for newcomers hacktoberfest Participation in the Hacktoberfest event help wanted Extra attention is needed .NET Pull requests that update .net code nuget packages size/L Denotes a PR that changes 100-499 lines, ignoring generated files. 🛠 WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Upgrade ElasticSearch dependencies
3 participants
@Mohammad-Haris @AppVeyorBot @guibranco