Remove binary serializer #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gstraccini
bot
added
🛠 WIP
github-actions
bot
added
the
size/L
![gstraccini[bot]](https://avatars.githubusercontent.com/in/480132?s=60&v=4){kind=small}
gstraccini
bot
added
the
🚦 awaiting triage
|
✅ Build CrispyWaffle 7.0.94 completed (commit 57732a4df7 by @Mohammad-Haris) |
guibranco
approved these changes
Jul 25, 2024
| @@ -118,6 +118,13 @@ Refer to [CONTRIBUTING.md](CONTRIBUTING.md) to learn how to contribute to this p | |||
| <table> | |||
| <tbody> | |||
| <tr> | |||
| <td align="center"> | |||
There was a problem hiding this comment.
A workflow/GH action updates this section automatically; don't worry. Once your code gets merged, it will add your data here!
| @@ -8,6 +8,13 @@ Refer to [CONTRIBUTING.md](https://github.com/guibranco/CrispyWaffle/blob/main/C | |||
| <table> | |||
| <tbody> | |||
| <tr> | |||
| <td align="center"> | |||
|
@Mohammad-Haris, great job. Thanks for the effort! I will merge it as soon as the CI checks conclude to run! 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #462
Before the change?
Library supported conversion of an object to binary format. But
BinaryFormatterhas security issues and was flagged as obsolete in .NET 7.0 and higher, hence removing the functionality for now.After the change?
Removed
BinarySerializerAdapterand its references.Pull request checklist
Does this introduce a breaking change?
Users using binary serialization might encounter errors.