Bump csharpier from 0.26.7 to 0.27.0 #289

dependabot · 2024-01-22T14:15:20Z

Bumps csharpier from 0.26.7 to 0.27.0.

Release notes

0.27.0 What's Changed

Improve formatting of lambda expressions #1066

Many thanks go to @Rudomitori for contributing a number of improvements to the formatting of lambda expressions.

Some examples of the improvements.

// input
var affectedRows = await _dbContext.SomeEntities
    .ExecuteUpdateAsync(
        x => 
            x.SetProperty(x => x.Name, x => command.NewName)
                .SetProperty(x => x.Title, x => command.NewTItle)
                .SetProperty(x => x.Count, x => x.Command.NewCount)
    );
// 0.27.0
var affectedRows = await _dbContext.SomeEntities
.ExecuteUpdateAsync(x =>
x.SetProperty(x => x.Name, x => command.NewName)
.SetProperty(x => x.Title, x => command.NewTItle)
.SetProperty(x => x.Count, x => x.Command.NewCount)
);

// input
builder.Entity<IdentityUserToken<string>>(b =>
{
    b.HasKey(
        l =>
            new
            {
                l.UserId,
                l.LoginProvider,
                l.Name
            }
    );
    b.ToTable("AspNetUserTokens");
});
// 0.27.0
builder.Entity<IdentityUserToken<string>>(b =>
{
b.HasKey(l => new
{
l.UserId,
l.LoginProvider,
l.Name
});
</tr></table>

... (truncated)

Changelog

Sourced from csharpier's changelog.

# 0.27.0

What's Changed

Improve formatting of lambda expressions #1066

Many thanks go to @Rudomitori for contributing a number of improvements to the formatting of lambda expressions.

Some examples of the improvements.

// input
var affectedRows = await _dbContext.SomeEntities
    .ExecuteUpdateAsync(
        x => 
            x.SetProperty(x => x.Name, x => command.NewName)
                .SetProperty(x => x.Title, x => command.NewTItle)
                .SetProperty(x => x.Count, x => x.Command.NewCount)
    );
// 0.27.0
var affectedRows = await _dbContext.SomeEntities
.ExecuteUpdateAsync(x =>
x.SetProperty(x => x.Name, x => command.NewName)
.SetProperty(x => x.Title, x => command.NewTItle)
.SetProperty(x => x.Count, x => x.Command.NewCount)
);

// input
builder.Entity<IdentityUserToken<string>>(b =>
{
    b.HasKey(
        l =>
            new
            {
                l.UserId,
                l.LoginProvider,
                l.Name
            }
    );
    b.ToTable("AspNetUserTokens");
});
// 0.27.0
builder.Entity<IdentityUserToken<string>>(b =>
{
b.HasKey(l => new
{
l.UserId,
l.LoginProvider,
l.Name
});
</tr></table>

... (truncated)

Commits

7d09173 Releasing 0.27.0 (#1128)
99206da Adding GRPC support to CSharpier to allow better communication with extension...
102c6e5 Fixing issue with #if being eaten in collection expression (#1120)
207353a Allowing new lines in initializers (#1113)
b634ee3 fixing some issues with the recent raw string literal changes from #975 (#1106)
3c8022c Only sort modifiers that we know should be sorted. (#1124)
bbbbbab Some syntax finder tweaks made while tracking down what modifiers look like o...
69dc6ef Cleaning up syntax finder a bit. Add readme (#1121)
0f07ce0 update doc
f49cf5d Minor update to EditorsTroubleshooting.md (#1118)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [csharpier](https://github.com/belav/csharpier) from 0.26.7 to 0.27.0. - [Release notes](https://github.com/belav/csharpier/releases) - [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md) - [Commits](belav/csharpier@0.26.7...0.27.0) --- updated-dependencies: - dependency-name: csharpier dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

guibranco

Automatically approved by gstraccini[bot]

guibranco · 2024-01-22T14:16:09Z

@dependabot squash and merge

codacy-production · 2024-01-22T14:41:53Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `8f39519`¹	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`8f39519`)	Report Missing	Report Missing	Report Missing
Head commit (`553d3f0`)	3378	1375	40.70%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#289)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

AppVeyorBot · 2024-01-22T14:55:52Z

✅ Build CrispyWaffle 4.3.293 completed (commit e20aaae265 by @dependabot[bot])

codecov · 2024-01-22T14:56:22Z

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (faaa37d) 37.43% compared to head (36299ac) 37.40%.

Files	Patch %	Lines
Src/CrispyWaffle/Log/LogConsumer.cs	15.00%	34 Missing ⚠️
...c/CrispyWaffle.ElasticSearch/Helpers/Extensions.cs	0.00%	8 Missing ⚠️
Src/CrispyWaffle/Composition/ServiceLocator.cs	72.41%	5 Missing and 3 partials ⚠️
...ffle.ElasticSearch/Log/ElasticSearchLogProvider.cs	0.00%	7 Missing ⚠️
...ispyWaffle/Log/Handlers/DefaultExceptionHandler.cs	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   37.43%   37.40%   -0.04%     
==========================================
  Files          71       71              
  Lines        3328     3280      -48     
  Branches      467      467              
==========================================
- Hits         1246     1227      -19     
+ Misses       1997     1968      -29     
  Partials       85       85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

guibranco · 2024-01-22T15:13:49Z

@gstraccini csharpier

gstraccini · 2024-01-22T15:14:08Z

Running CSharpier on this branch! 🔧

gstraccini · 2024-01-22T15:14:35Z

✅ CSharpier result:

Error ./Src/CrispyWaffle.Elmah/ElmahExceptionHandler.cs - Was not formatted.
  ----------------------------- Expected: Around Line 96 -----------------------------
              foreach (
                  var additionalProvider in _additionalProviders.Where(p =>
                      p.Item2 == ExceptionLogType.Full
  ----------------------------- Actual: Around Line 96 -----------------------------
              foreach (
                  var additionalProvider in _additionalProviders.Where(
                      p => p.Item2 == ExceptionLogType.Full
  
Error ./Src/CrispyWaffle/Log/LogConsumer.cs - Was not formatted.
  ----------------------------- Expected: Around Line 317 -----------------------------
              foreach (
                  var provider in _providers.Where(p =>
                      _filters.All(f =>
  ----------------------------- Actual: Around Line 317 -----------------------------
              foreach (
                  var provider in _providers.Where(
                      p =>
  
Error ./Src/CrispyWaffle/Extensions/EnumExtensions.cs - Was not formatted.
  ----------------------------- Expected: Around Line 32 -----------------------------
              var field = type.GetFields()
                  .Select(f => new
                  {
  ----------------------------- Actual: Around Line 32 -----------------------------
              var field = type.GetFields()
                  .Select(
                      f =>
  
Error ./Src/CrispyWaffle/Composition/ServiceLocator.cs - Was not formatted.
  ----------------------------- Expected: Around Line 75 -----------------------------
                  .SelectMany(a => a.GetTypes())
                  .Where(a =>
                      a != null
  ----------------------------- Actual: Around Line 75 -----------------------------
                  .SelectMany(a => a.GetTypes())
                  .Where(
                      a =>
  
Error ./Src/CrispyWaffle.ElasticSearch/Log/ElasticSearchLogProvider.cs - Was not formatted.
  ----------------------------- Expected: Around Line 107 -----------------------------
              var retentionDays = _logRetentionDays;
              _client.DeleteByQuery<LogMessage>(d =>
                  d.Index(_indexName)
  ----------------------------- Actual: Around Line 107 -----------------------------
              var retentionDays = _logRetentionDays;
              _client.DeleteByQuery<LogMessage>(
                  d =>
  
Error ./Src/CrispyWaffle.ElasticSearch/Helpers/Extensions.cs - Was not formatted.
  ----------------------------- Expected: Around Line 67 -----------------------------
  
              _connector.Client.Indices.BulkAlias(a =>
                  a.Add(add => add.Index(indexName).Alias(alias))
  ----------------------------- Actual: Around Line 67 -----------------------------
  
              _connector.Client.Indices.BulkAlias(
                  a => a.Add(add => add.Index(indexName).Alias(alias))
  
Error ./Src/CrispyWaffle/Log/Handlers/DefaultExceptionHandler.cs - Was not formatted.
  ----------------------------- Expected: Around Line 124 -----------------------------
              foreach (
                  var additionalProvider in _additionalProviders.Where(p =>
                      p.Item2 == ExceptionLogType.Full
  ----------------------------- Actual: Around Line 124 -----------------------------
              foreach (
                  var additionalProvider in _additionalProviders.Where(
                      p => p.Item2 == ExceptionLogType.Full

dependabot · 2024-01-22T15:17:31Z

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

codacy-production · 2024-01-22T16:47:03Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.07%	✅ 49.11%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`faaa37d`)	3378	1375	40.70%
Head commit (`36299ac`)	3330 (-48)	1353 (-22)	40.63% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#289)	112	55	49.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

AppVeyorBot · 2024-01-22T17:00:36Z

✅ Build CrispyWaffle 4.3.304 completed (commit 6f270ca8c4 by @)

AppVeyorBot · 2024-01-22T18:00:19Z

✅ Build CrispyWaffle 4.3.309 completed (commit d6ea93958c by @guibranco)

sonarcloud · 2024-01-22T19:35:41Z

Quality Gate failed

Failed conditions

48.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

AppVeyorBot · 2024-01-22T19:36:41Z

✅ Build CrispyWaffle 4.3.316 completed (commit 33984c6303 by @guibranco)

dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file nuget packages labels Jan 22, 2024

dependabot bot requested a review from guibranco January 22, 2024 14:15

dependabot bot assigned guibranco Jan 22, 2024

github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2024

guibranco enabled auto-merge (squash) January 22, 2024 14:16

gstraccini bot approved these changes Jan 22, 2024

View reviewed changes

guibranco approved these changes Jan 22, 2024

View reviewed changes

CSharpier format

93a85e1

github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2024

Merge branch 'main' into dependabot/nuget/csharpier-0.27.0

acc5275

Merge branch 'main' into dependabot/nuget/csharpier-0.27.0

36299ac

guibranco disabled auto-merge January 23, 2024 10:15

guibranco merged commit d7972a5 into main Jan 23, 2024
22 of 25 checks passed

guibranco deleted the dependabot/nuget/csharpier-0.27.0 branch January 23, 2024 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump csharpier from 0.26.7 to 0.27.0 #289

Bump csharpier from 0.26.7 to 0.27.0 #289

dependabot bot commented on behalf of github Jan 22, 2024 •

edited

Loading

guibranco left a comment

guibranco commented Jan 22, 2024

codacy-production bot commented Jan 22, 2024

AppVeyorBot commented Jan 22, 2024

codecov bot commented Jan 22, 2024 •

edited

Loading

guibranco commented Jan 22, 2024

gstraccini bot commented Jan 22, 2024

gstraccini bot commented Jan 22, 2024

dependabot bot commented on behalf of github Jan 22, 2024

codacy-production bot commented Jan 22, 2024 •

edited

Loading

AppVeyorBot commented Jan 22, 2024

AppVeyorBot commented Jan 22, 2024

sonarcloud bot commented Jan 22, 2024

AppVeyorBot commented Jan 22, 2024

Bump csharpier from 0.26.7 to 0.27.0 #289

Bump csharpier from 0.26.7 to 0.27.0 #289

Conversation

dependabot bot commented on behalf of github Jan 22, 2024 • edited Loading

0.27.0

What's Changed

Improve formatting of lambda expressions #1066

What's Changed

Improve formatting of lambda expressions #1066

guibranco left a comment

Choose a reason for hiding this comment

guibranco commented Jan 22, 2024

codacy-production bot commented Jan 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

AppVeyorBot commented Jan 22, 2024

codecov bot commented Jan 22, 2024 • edited Loading

Codecov Report

guibranco commented Jan 22, 2024

gstraccini bot commented Jan 22, 2024

gstraccini bot commented Jan 22, 2024

dependabot bot commented on behalf of github Jan 22, 2024

codacy-production bot commented Jan 22, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

AppVeyorBot commented Jan 22, 2024

AppVeyorBot commented Jan 22, 2024

sonarcloud bot commented Jan 22, 2024

Quality Gate failed

AppVeyorBot commented Jan 22, 2024

dependabot bot commented on behalf of github Jan 22, 2024 •

edited

Loading

codecov bot commented Jan 22, 2024 •

edited

Loading

codacy-production bot commented Jan 22, 2024 •

edited

Loading