Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retry rule in FtpClient.cs #212

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Conversation

Yousef-Majidi
Copy link
Contributor

@Yousef-Majidi Yousef-Majidi commented Oct 15, 2023

This closes #211

I've removed the retry rule in the CreateInternal method in FtpClient.cs:

  • removed the while(true) statement
  • removed the attempts variable and incrementation
  • removed the if statement checking for the attempt count

In the spirit of improving the code, I also slightly changed the ExistsInternal method to simplify the resource management and simplify the code slightly.

but let me know if you want me to revert the changes made to ExistsInternal

P.S. Could you kindly please add the label hacktoberfest-accepted to this pull request?

Thank you.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2023
@AppVeyorBot
Copy link

@guibranco guibranco added the hacktoberfest Participation in the Hacktoberfest event label Oct 15, 2023
@guibranco
Copy link
Owner

@Yousef-Majidi thanks for the PR and the improvements! Accepted.

Also, I added the label that you requested! When you refresh your Hacktoberfest Profile it will be there

@guibranco guibranco merged commit 8065aaf into guibranco:main Oct 15, 2023
7 of 9 checks passed
@Yousef-Majidi
Copy link
Contributor Author

Thank you @guibranco for the quick merge.

I noticed you added the hacktoberfest label, and I appreciate that, but could you also add hacktoberfest-accepted as well, please?

It was a pleasure contributing to your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Participation in the Hacktoberfest event size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove retry rules from FtpClient class.
3 participants