Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Chromatic Action - Pin chromaui/action to 11.3.0 #1122

Merged
merged 2 commits into from
May 8, 2024

Conversation

andrewHEguardian
Copy link
Contributor

@andrewHEguardian andrewHEguardian commented May 7, 2024

What does this change?

Pin the Chromatic action CLI version.

How to test

Github actions fail without this change, pass with the change

Images

Before

image

After
See this PR's checks!

@andrewHEguardian andrewHEguardian changed the title Failing Chromatic Action Fix Failing Chromatic Action - Pin chromaui/action to 11.3.0 May 7, 2024
@andrewHEguardian andrewHEguardian marked this pull request as ready for review May 7, 2024 10:46
Copy link
Contributor

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approving to allow Chromatic to run on my PR in #1123 😄

As a side note, should this repo have a CODEOWNERS file?

@andrewHEguardian andrewHEguardian merged commit 9ddfec4 into main May 8, 2024
5 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/chromatic-action branch May 8, 2024 15:11
@andrewHEguardian
Copy link
Contributor Author

As a side note, should this repo have a CODEOWNERS file?

Sounds like a good idea. I'll ask the team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants