Support Scala 3 & Play 3 - drop oldest Play & Scala versions #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Play v2.9 introduces support for Scala 3 - Play v3.0 also switches from Akka to Pekko, which is great from a licensing perspective (Play v2.9 had to ship with old versions of Akka to avoid the BSL license: https://www.playframework.com/documentation/3.0.x/General#How-Play-Deals-with-Akkas-License-Change ). Here, we're upgrading `play-secret-rotation` to support these new latest versions of Play, and add the new welcome Scala 3 support! To reduce maintenance build complexity, we're also dropping support for Play 2.6, and Scala 2.12. Note, Matthias Kurz made some interesting suggestions about restructuring the multi-Play support in this project and also `google-play-auth`: guardian/frontend#26677 (comment) ...however, for `play-secret-rotation` at least, the changes didn't appear necessary, as `play-secret-rotation` actually has a fairly minimal dependency on Play, and doesn't touch Akka/Pekko related code.
rtyley
added a commit
that referenced
this pull request
Nov 8, 2023
Not long after I was warned that symbolic links are dangerous, I broke some symbolic links! In #411 I dropped support for Play v2.6, but didn't correctly update all the symbolic links in this project to point to the Play 2.7 version of the code - so all the links were broken, and the result was that the published artifacts did not have `RotatingSecretComponents` in them. Darn.
mkurz
reviewed
Nov 9, 2023
| @@ -1,21 +1,21 @@ | |||
| import ReleaseTransformations._ | |||
|
|
|||
| lazy val baseSettings = Seq( | |||
| scalaVersion := "2.12.18", | |||
| scalaVersion := "2.13.11", | |||
There was a problem hiding this comment.
Why did you not upgrade to 2.13.12? Is there a reason for that, like compile errors?
There was a problem hiding this comment.
Ah, we recently got slightly burned on a different project by a dependency that failed on Scala 2.13.12 (see scala/bug#12862 & scala/bug#12862 (comment))... we're not using that dependency on this project, and I could have upgraded to 2.13.12 - I just needed a bit of space to breathe and not handle another complexity right now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Play v2.9 introduces support for Scala 3 - Play v3.0 also switches from Akka to Pekko, which is great from a licensing perspective (Play v2.9 had to ship with old versions of Akka to avoid the BSL license).
Here, we're upgrading
play-secret-rotationto support these new latest versions of Play, and add the new welcome Scala 3 support! To reduce maintenance build complexity, we're also dropping support for Play 2.6, and Scala 2.12.Note, Matthias Kurz made some interesting suggestions about restructuring the multi-Play support in this project and also
google-play-auth: guardian/frontend#26677 (comment) ...however, forplay-secret-rotationat least, the changes didn't appear necessary, asplay-secret-rotationactually has a fairly minimal dependency on Play, and doesn't touch Akka/Pekko related code.