Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix husky pre-commit hook #314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

twrichards
Copy link
Collaborator

run fnm use and nvm use to ensure correct version of node before executing the various steps in the pre-commit hook (configured via husky)

Broken since #307

@twrichards twrichards marked this pull request as ready for review October 28, 2024 09:02
@twrichards twrichards requested a review from a team as a code owner October 28, 2024 09:02
…executing the various steps in the `pre-commit` hook (configured via husky)
@bryophyta
Copy link

the code looks good to me but I haven't been able to trigger the hook itself...

./scripts/setup.sh
touch temp_file
git add temp_file
git commit -m "Test commit"
git push

Am I missing a step to get the hooks set up?

@twrichards
Copy link
Collaborator Author

the code looks good to me but I haven't been able to trigger the hook itself...

./scripts/setup.sh
touch temp_file
git add temp_file
git commit -m "Test commit"
git push

Am I missing a step to get the hooks set up?

its a pre-commit hook, so shouldn't need the git push (basically the commit should be slow), not sure why it's not running for you though, will message you offline...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants