Use Circe's deepDropNullValues instead of withoutNull
#27673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DotcomRenderingUtils.withoutNull` is not recursive, therefore nested `null` fields make it through to DCAR, causing validation errors.
SiAdcock
approved these changes
Dec 13, 2024
ashishpuliyel
approved these changes
Dec 13, 2024
marjisound
approved these changes
Dec 13, 2024
JamieB-gu
deleted the
use-circe-deep-drop-null-values-not-without-null
branch
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @JamieB-gu 12 minutes and 3 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @JamieB-gu 13 minutes and 8 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DotcomRenderingUtils.withoutNullis not recursive, therefore nestednullfields make it through to DCAR, causing validation errors.Issue introduced in #27641.