Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace collections on europe front if participating in the Europe beta test #27635

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Nov 22, 2024

What is the value of this and can you measure success?

Setting up phase 2 of the Europe beta experiment test plan to show the containers on the Europe beta front instead of those on the Europe front for users participating in the test:

  • If a user requests the europe front

    • and is participating in the test, the europe front is returned with the collections swapped out for the ones on the hidden europe-beta front
    • and is not participating in the test, the europe collections are returned as usual.
  • If a user requests any other front and is either participating or not participating in the Europe beta test, the collections configured for that front are unchanged.

Table to demonstrate the above logic:

front requested in test not in test
europe europe front with europe-beta collections europe front with europe collections
europe-beta 404 not found 404 not found
uk uk front with uk collections uk front with uk collections

Trello ticket link

What does this change?

Adjusts the logic in renderFrontPressResult for fetching the futureFaciaPage to swap the collections returned in the response if a user is participating in the Europe beta test and they are requesting the Europe front.

All other fields remain the same apart from collections which returns those on the hidden europe-beta front instead of the usual collections returned from the europe front.

Screenshots

Checklist

How to test

@cemms1 cemms1 self-assigned this Nov 22, 2024
@cemms1 cemms1 marked this pull request as ready for review November 26, 2024 15:43
@cemms1 cemms1 requested a review from a team as a code owner November 26, 2024 15:43
@cemms1 cemms1 force-pushed the cemms1/replace-containers-for-europe-test branch from 4c43630 to a96d54c Compare November 27, 2024 13:09
Copy link
Contributor

@Georges-GNM Georges-GNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it when the branch was up on code earlier this week - looks good to me.

@cemms1 cemms1 force-pushed the cemms1/replace-containers-for-europe-test branch from a96d54c to 9017da9 Compare November 29, 2024 12:37
@cemms1 cemms1 merged commit 4303183 into main Nov 29, 2024
6 checks passed
@cemms1 cemms1 deleted the cemms1/replace-containers-for-europe-test branch November 29, 2024 13:33
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @cemms1 13 minutes and 3 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants