Editions crossword cryptic and quick data #27604
Conversation
| crosswords: EditionsCrosswordRenderingDataModel, | ||
| )(implicit request: RequestHeader): Future[Result] = { | ||
| val json = EditionsCrosswordRenderingDataModel.toJson(crosswords) | ||
| post(ws, json, Configuration.rendering.articleBaseURL + "/EditionsCrossword", CacheTime.Facia) |
There was a problem hiding this comment.
All of the other post requests in the DotcomRenderingService are using this cache time including for articles. Its confusingly named, maybe we can look at reviewing this separately.
There was a problem hiding this comment.
I think generally post requests for articles are using a different cache time based on their metadata:
with CacheTime.Default as the fallback:
frontend/common/app/model/meta.scala
Line 326 in c7b403b
?
Post requests for fronts and tag pages are using CacheTime.Facia, but that's likely correct because they're examples of "facia" content. I agree that probably we should review getMedia, getImageContent and getGallery's usage of CacheTime.Facia; have captured this in #27628.
Given this, I don't think it's what we want to use here. Perhaps CacheTime.Default is the correct choice if we don't have a specific, different cache setting for these pages? @SiAdcock @arelra any thoughts?
There was a problem hiding this comment.
Thanks. I didn't think about this much and just copied what was being done for similar use cases. What about 50 minutes surrogate and 5 minutes for client cache arbitrarily. This is a simple optimisation unlikely to effect users too much unless that are hitting crosswords in press reader at midnight
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @DanielCliftonGuardian 13 minutes and 41 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @DanielCliftonGuardian 14 minutes and 1 second ago)
|
What is the value of this and can you measure success?
This PR adds functionality to the Crosswords Controller to send JSON data for the latest cryptic and quick crosswords to DCR
What does this change?
Resolves guardian/dotcom-rendering#12799