Add edition targeting to liveblog top sponsorship #27279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dskamiotis
approved these changes
Jul 9, 2024
Comment on lines
+311
to
+313
| val hasEditionTargeting = targeting.editions.nonEmpty | ||
|
|
||
| isLiveblogTopSlot && isLiveblogContentType && targetsOnlyAllowedSections && isMobileBreakpoint && isSponsorship && hasEditionTargeting |
There was a problem hiding this comment.
Is it right to assume its looking at the targeting data received from GAM at this point?
emma-imber
approved these changes
Jul 9, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (created by @Jakeii and merged by @dskamiotis 12 minutes and 1 second ago)
|
|
Seen on FRONTS-PROD (created by @Jakeii and merged by @dskamiotis 12 minutes and 11 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Only set
hasLiveblogTopSponsorshipif the sponsorship/line-item has edition targeting and it matches