-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Email Signup to send verification email. #27277
Conversation
Looks good - could you rebase these commits down to make it easier for future people visiting this code to understand why it's been changed? |
An alternative is to squash & merge the PR so it appears at a single item in the git history for future travellers :) |
…tter subscription This changes the newsletter page to send email confirmation before email signup. Sends a post request to /consent-email instead of /consent-signup.
d935f51
to
9967c5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 ✅
(Just make sure you test it before merging!)
I've tested and I received the email as expected. |
Seen on ADMIN-PROD (merged by @akinsola-guardian 13 minutes and 3 seconds ago)
|
Seen on FRONTS-PROD (merged by @akinsola-guardian 14 minutes and 7 seconds ago)
|
What is the value of this and can you measure success?
This changes the newsletter page to send email confirmation before email signup.
What does this change?
Sends a post request to
/consent-email
instead ofconsent-signup
Screenshots
Checklist