Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Email Signup to send verification email. #27277

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

akinsola-guardian
Copy link
Contributor

@akinsola-guardian akinsola-guardian commented Jul 2, 2024

What is the value of this and can you measure success?

This changes the newsletter page to send email confirmation before email signup.

What does this change?

Sends a post request to /consent-email instead of consent-signup

Screenshots

Checklist

@akinsola-guardian akinsola-guardian changed the title Update EmailSignupController.scala Update Email Signup to send verification email. Jul 2, 2024
@akinsola-guardian akinsola-guardian marked this pull request as ready for review July 11, 2024 09:21
@akinsola-guardian akinsola-guardian requested a review from a team as a code owner July 11, 2024 09:21
@raphaelkabo
Copy link
Contributor

Looks good - could you rebase these commits down to make it easier for future people visiting this code to understand why it's been changed?

@mxdvl
Copy link
Contributor

mxdvl commented Jul 11, 2024

Looks good - could you rebase these commits down to make it easier for future people visiting this code to understand why it's been changed?

An alternative is to squash & merge the PR so it appears at a single item in the git history for future travellers :)

…tter subscription

This changes the newsletter page to send email confirmation before email signup. Sends a post request to /consent-email instead of /consent-signup.
@akinsola-guardian akinsola-guardian force-pushed the al-update-email-signup-to-send-email branch from d935f51 to 9967c5c Compare July 11, 2024 10:35
Copy link
Contributor

@raphaelkabo raphaelkabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✅

(Just make sure you test it before merging!)

@akinsola-guardian
Copy link
Contributor Author

🚀 ✅

(Just make sure you test it before merging!)

I've tested and I received the email as expected.

@akinsola-guardian akinsola-guardian merged commit 8353ee3 into main Jul 11, 2024
6 checks passed
@akinsola-guardian akinsola-guardian deleted the al-update-email-signup-to-send-email branch July 11, 2024 11:44
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @akinsola-guardian 13 minutes and 3 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @akinsola-guardian 14 minutes and 7 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants