Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ab test with extra dash to match convention #27274

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

sookburt
Copy link
Contributor

@sookburt sookburt commented Jul 1, 2024

What is the value of this and can you measure success?

A tiny change to fix the ab test which is not working from the PR27261

What does this change?

It adds a dash to the test name in ABTestSwitches.scala to match the slightly different ab test name elsewhere in the frontend code where the blog part is title case accidentally (like StickyLiveBlogAskTest).

Screenshots

No visible change other than the sticky liveblog showing for the variant - see DCR PR11723 which contains screenshots.

Checklist

@sookburt sookburt marked this pull request as ready for review July 1, 2024 16:29
@sookburt sookburt requested a review from a team as a code owner July 1, 2024 16:29
@sookburt sookburt merged commit 9ef42b7 into main Jul 2, 2024
6 checks passed
@sookburt sookburt deleted the skb/fix-ab-test-name-to-match branch July 2, 2024 08:29
@prout-bot
Copy link
Collaborator

Overdue on FRONTS-PROD, ADMIN-PROD (merged by @sookburt 30 minutes and 5 seconds ago) What's gone wrong?

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @sookburt 1 hour, 4 minutes and 37 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants