Enable increasing load from switchboard #27236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anna Beddow <[email protected]> Co-authored-by: Jamie B <[email protected]> Co-authored-by: George B <[email protected]> Co-authored-by: Ioanna Kokkini <[email protected]> Co-authored-by: Daniel Clifton <[email protected]> Co-authored-by: Dom Lander <[email protected]>
mxdvl
commented
Jun 19, 2024
Comment on lines
+116
to
+119
| val surrogateMaxAge = cacheTime.surrogateSeconds match { | ||
| case Some(age) if LongCacheSwitch.isSwitchedOn => age | ||
| case _ => cacheTime.cacheSeconds | ||
| } |
There was a problem hiding this comment.
Refactored for readability
abeddow91
approved these changes
Jun 20, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @mxdvl 10 minutes and 59 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @mxdvl 11 minutes and 10 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Enable load testing of our system without a deploy.
Part of guardian/dotcom-rendering#11670
What does this change?
Conditinally set the
Surrogate-Controlbased on a switchChecklist